Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1943333002: Add sync in vulkan when writing to linear texture (Closed)

Created:
4 years, 7 months ago by egdaniel
Modified:
4 years, 7 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add sync in vulkan when writing to linear texture Since mapping memory of linear textures happens in real time and not via a command buffer, we need to flush all work that access the texture before uploading new data to it. Even if the texture is already in the correct layout, General, we still need to make sure all work has been finished. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1943333002 Committed: https://skia.googlesource.com/skia/+/bdf8811b3126ab08ccff08b5e647b80cae5bd087

Patch Set 1 #

Patch Set 2 : always sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/gpu/vk/GrVkGpu.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
egdaniel
4 years, 7 months ago (2016-05-03 14:08:59 UTC) #3
jvanverth1
lgtm
4 years, 7 months ago (2016-05-03 14:09:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943333002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943333002/20001
4 years, 7 months ago (2016-05-03 14:14:34 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 14:25:59 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/bdf8811b3126ab08ccff08b5e647b80cae5bd087

Powered by Google App Engine
This is Rietveld 408576698