Move extension_messages.h to extensions/common.

Move extension_messages.h to extensions/common.

Move most of chrome/common/extensions/extension_messages.h
into a new extensions/common/extension_messages.h file.

WebApplicationInfo-related IPC definitions are now in
chrome/common/extensions/chrome_extension_messages.h.

BUG=335159
TBR=sky@chromium.org,cdn@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256831

[Daniel Erat, 2014-03-11 05:34:41]

https://codereview.chromium.org/194333002/diff/1/chrome/renderer/extensions/e...
File chrome/renderer/extensions/extension_helper.cc (right):

https://codereview.chromium.org/194333002/diff/1/chrome/renderer/extensions/e...
chrome/renderer/extensions/extension_helper.cc:166:
IPC_MESSAGE_HANDLER(ChromeExtensionMsg_GetApplicationInfo,
is this (mixing a ChromeExtensionMsg in with all of the ExtensionMsg handlers in
ExtensionHelper) considered kosher? i'm not at all familiar with IPC handlers.

(but i can also believe that most of this file will need to move over to
extensions/ at some point, so...)

[not at google - send to devlin, 2014-03-11 14:27:34]

extension messages lgtm

https://codereview.chromium.org/194333002/diff/1/chrome/renderer/extensions/e...
File chrome/renderer/extensions/extension_helper.cc (right):

https://codereview.chromium.org/194333002/diff/1/chrome/renderer/extensions/e...
chrome/renderer/extensions/extension_helper.cc:166:
IPC_MESSAGE_HANDLER(ChromeExtensionMsg_GetApplicationInfo,
On 2014/03/11 05:34:42, Daniel Erat wrote:
> is this (mixing a ChromeExtensionMsg in with all of the ExtensionMsg handlers
in
> ExtensionHelper) considered kosher? i'm not at all familiar with IPC handlers.
> 
> (but i can also believe that most of this file will need to move over to
> extensions/ at some point, so...)

Seems fine, or at least, something to deal with if/when this file needs to move
into extensions/.

[Daniel Erat, 2014-03-11 21:34:06]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2014-03-11 22:08:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/194333002/40001

[commit-bot: I haz the power, 2014-03-12 02:07:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-12 02:07:53]

Try jobs failed on following builders: linux_chromium_rel

[Daniel Erat, 2014-03-12 09:35:32]

The CQ bit was checked by derat@chromium.org

[Daniel Erat, 2014-03-12 09:35:49]

The CQ bit was unchecked by derat@chromium.org

[Daniel Erat, 2014-03-12 13:28:53]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2014-03-12 13:29:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/194333002/40001

[commit-bot: I haz the power, 2014-03-12 13:29:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-12 13:29:45]

Failed to apply patch for extensions/browser/DEPS:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file extensions/browser/DEPS
  Hunk #1 FAILED at 19.
  1 out of 1 hunk FAILED -- saving rejects to file extensions/browser/DEPS.rej

Patch:       extensions/browser/DEPS
Index: extensions/browser/DEPS
diff --git a/extensions/browser/DEPS b/extensions/browser/DEPS
index
f445ff61c9c6af2cf6427aa728e5be966bbf1896..2dddf506bbdbfd9ff3a18aacd9e71d0f2bac7036
100644
--- a/extensions/browser/DEPS
+++ b/extensions/browser/DEPS
@@ -19,7 +19,6 @@ include_rules = [
   "+chrome/browser/extensions/extension_host.h",
   "+chrome/browser/extensions/extension_service.h",
   "+chrome/browser/renderer_host/chrome_render_message_filter.h",
-  "+chrome/common/extensions/extension_messages.h",
   "+chrome/common/extensions/features/feature_channel.h",
   "+grit/generated_resources.h",
 ]

[Daniel Erat, 2014-03-13 05:23:16]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2014-03-13 05:23:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/194333002/60001

[commit-bot: I haz the power, 2014-03-13 07:05:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-13 07:05:32]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_rel

[Daniel Erat, 2014-03-13 07:53:13]

On 2014/03/13 07:05:32, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   tryserver.chromium on linux_chromium_rel

AutomationApiTest.SanityCheck is a brand-new test. as far as i can tell, the
failure isn't this change's fault -- the test passed for me the few times that
i've run it locally with this change in a linux release build.

[Daniel Erat, 2014-03-13 07:53:20]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2014-03-13 07:53:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/194333002/60001

[commit-bot: I haz the power, 2014-03-13 10:29:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-13 10:29:21]

Failed to apply patch for ipc/ipc_message_start.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file ipc/ipc_message_start.h
  Hunk #1 FAILED at 97.
  1 out of 1 hunk FAILED -- saving rejects to file ipc/ipc_message_start.h.rej

Patch:       ipc/ipc_message_start.h
Index: ipc/ipc_message_start.h
diff --git a/ipc/ipc_message_start.h b/ipc/ipc_message_start.h
index
7bbde9e1ac539846cf4a4c1bffbccfc9f4931ece..5aaa16c0a1c4cdee3d5015cdb49acb0fbcec8fcd
100644
--- a/ipc/ipc_message_start.h
+++ b/ipc/ipc_message_start.h
@@ -97,6 +97,7 @@ enum IPCMessageStart {
   CastMsgStart,
   CdmMsgStart,
   ScreenOrientationMsgStart,
+  ChromeExtensionMsgStart,
   LastIPCMsgStart  // Must come last.
 };

[Daniel Erat, 2014-03-13 11:32:15]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2014-03-13 11:32:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/194333002/80001

[commit-bot: I haz the power, 2014-03-13 15:07:13]

Change committed as 256831

[Jeffrey Yasskin, 2014-03-18 18:34:28]

This needs to move/copy the "For security review of IPC message files." section
of the OWNERS file too.

[Daniel Erat, 2014-03-18 21:00:42]

On 2014/03/18 18:34:28, Jeffrey Yasskin wrote:
> This needs to move/copy the "For security review of IPC message files."
section
> of the OWNERS file too.

Thanks, will do.

[Cris Neckar, 2014-03-18 21:13:44]

IPC lgtm

[Daniel Erat, 2014-03-19 00:22:41]

On 2014/03/18 21:13:44, Cris Neckar wrote:
> IPC lgtm

OWNERS change is at https://codereview.chromium.org/197283034.