Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Unified Diff: src/objects-inl.h

Issue 1943303002: Make it possible to set a getter and a setter at the same time (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.h
index 60a140b79c58f0fda45e1126dc97d0669ed142c0..017ca3425a592f46ffee580f9de2fba2258cde5c 100644
--- a/src/objects-inl.h
+++ b/src/objects-inl.h
@@ -7278,7 +7278,10 @@ bool AccessorPair::Equals(AccessorPair* pair) {
bool AccessorPair::Equals(Object* getter_value, Object* setter_value) {
- return (getter() == getter_value) && (setter() == setter_value);
+ return ((getter()->IsTheHole() && getter_value->IsNull()) ||
+ (getter() == getter_value)) &&
+ ((setter()->IsTheHole() && setter_value->IsNull()) ||
+ (setter() == setter_value));
}
« src/objects.cc ('K') | « src/objects.cc ('k') | test/cctest/test-field-type-tracking.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698