Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3665)

Unified Diff: chrome/browser/views/about_network_dialog.h

Issue 19433: Factor out the common parts of the about network dialog. I will be using this... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/views/about_network_dialog.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/about_network_dialog.h
===================================================================
--- chrome/browser/views/about_network_dialog.h (revision 8817)
+++ chrome/browser/views/about_network_dialog.h (working copy)
@@ -6,6 +6,7 @@
#define CHROME_BROWSER_VIEWS_ABOUT_NETWORK_DIALOG_H_
#include "base/singleton.h"
+#include "chrome/browser/views/logging_about_dialog.h"
#include "chrome/views/base_button.h"
#include "chrome/views/dialog_delegate.h"
@@ -14,9 +15,8 @@
class TextField;
} // namespace views
-class AboutNetworkDialog : public views::DialogDelegate,
- public views::BaseButton::ButtonListener,
- public views::View {
+class AboutNetworkDialog : public LoggingAboutDialog,
+ public views::BaseButton::ButtonListener {
public:
// This dialog is a singleton. If the dialog is already opened, it won't do
// anything, so you can just blindly call this function all you want.
@@ -24,10 +24,6 @@
virtual ~AboutNetworkDialog();
- // Appends the given string to the dialog box. This is called by the job
- // tracker (see the .cc file) when "stuff happens."
- void AppendText(const std::wstring& text);
-
// Returns true if we're currently tracking network operations.
bool tracking() const { return tracking_; }
@@ -36,25 +32,16 @@
AboutNetworkDialog();
- // Sets up all UI controls for the dialog.
- void SetupControls();
-
- virtual gfx::Size GetPreferredSize();
- virtual views::View* GetContentsView();
- virtual int GetDialogButtons() const;
- virtual std::wstring GetWindowTitle() const;
- virtual void Layout();
-
- // views::WindowDelegate (via view::DialogDelegate).
- virtual bool CanResize() const;
-
- // views::BaseButton::ButtonListener.
+ // views::BaseButton::ButtonListener implementation.
virtual void ButtonPressed(views::BaseButton* button);
+ // LoggingAboutDialog implementation.
+ virtual void SetupButtonColumnSet(views::ColumnSet* set);
+ virtual void AddButtonControlsToLayout(views::GridLayout* layout);
+
views::TextButton* track_toggle_;
views::TextButton* show_button_;
views::TextButton* clear_button_;
- views::TextField* text_field_;
// Set to true when we're tracking network status.
bool tracking_;
« no previous file with comments | « no previous file | chrome/browser/views/about_network_dialog.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698