Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1943263002: [heap] Fix clearing slots for map and size during LeftTrimFixedArray (Closed)

Created:
4 years, 7 months ago by Michael Lippautz
Modified:
4 years, 7 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Jakob Kummerow, Camillo Bruni
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Fix clearing slots for map and size during LeftTrimFixedArray BUG=chromium:598319 LOG=N Committed: https://crrev.com/5aa1d9c3cfde4389fb5a34e98a5dccbca9dc9f12 Cr-Commit-Position: refs/heads/master@{#35970}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/heap/heap.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Michael Lippautz
Ulan: PTAL Camillo/Jakob: FYI, this should fix the IsValidSlot() issue in the bug. Unfortunately this ...
4 years, 7 months ago (2016-05-03 10:00:31 UTC) #3
ulan
lgtm, thanks for fixing!
4 years, 7 months ago (2016-05-03 10:01:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943263002/1
4 years, 7 months ago (2016-05-03 10:04:52 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 10:26:40 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5aa1d9c3cfde4389fb5a34e98a5dccbca9dc9f12 Cr-Commit-Position: refs/heads/master@{#35970}
4 years, 7 months ago (2016-05-03 10:27:35 UTC) #10
Yang
4 years, 7 months ago (2016-05-03 13:04:55 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1947473002/ by yangguo@chromium.org.

The reason for reverting is: GC-stress failures:
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/....

Powered by Google App Engine
This is Rietveld 408576698