Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 1943243003: [turbofan] Make Pipeline more private. (Closed)

Created:
4 years, 7 months ago by Michael Starzinger
Modified:
4 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_turbofan-fix-trace-turbo
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Make Pipeline more private. By now the Pipeline class can no longer be used to construct instances from the outside. The constructor and all non-exposed helpers can be made private. R=bmeurer@chromium.org Committed: https://crrev.com/3394e88964d55dedc9d64faae2a545a8e400553e Cr-Commit-Position: refs/heads/master@{#35978}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -24 lines) Patch
M src/compiler/pipeline.h View 3 chunks +21 lines, -22 lines 0 comments Download
M src/compiler/pipeline.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
Michael Starzinger
4 years, 7 months ago (2016-05-03 11:28:29 UTC) #1
Benedikt Meurer
lgtm
4 years, 7 months ago (2016-05-03 11:35:26 UTC) #2
commit-bot: I haz the power
This CL has an open dependency (Issue 1946523002 Patch 1). Please resolve the dependency and ...
4 years, 7 months ago (2016-05-03 11:39:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943243003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943243003/1
4 years, 7 months ago (2016-05-03 11:52:23 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 11:56:27 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 11:56:54 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3394e88964d55dedc9d64faae2a545a8e400553e
Cr-Commit-Position: refs/heads/master@{#35978}

Powered by Google App Engine
This is Rietveld 408576698