Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1943233002: Revert of Add InputConnection-to-JavaScript tests for key input (Closed)

Created:
4 years, 7 months ago by henrika (OOO until Aug 14)
Modified:
4 years, 7 months ago
CC:
chongz, chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, Peter Beverloo, yosin_UTC9, yabinh
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add InputConnection-to-JavaScript tests for key input (patchset #3 id:40001 of https://codereview.chromium.org/1840993002/ ) Reason for revert: Breaks tests on Android, see e.g. https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests%20(dbg) Original issue's description: > Add InputConnection-to-JavaScript tests for key input > > commitText() is in effect almost the same as calling setComposingText() and > finishComposingText() in a batch edit. > > However, one difference is that the latter triggers composition events > in the DOM. This test clarifies the difference. > > This is the first Java-to-JavaScript test for key input system. > > BUG=578016 > > Committed: https://crrev.com/b2d5ef4470d26f1f5e5d02fefca18af139e4a744 > Cr-Commit-Position: refs/heads/master@{#391176} TBR=aelias@chromium.org,tedchoc@chromium.org,changwan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=578016 Committed: https://crrev.com/1882fb4865d3e8448bd2b62c0c66bf9937696725 Cr-Commit-Position: refs/heads/master@{#391189}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -206 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeLollipopTest.java View 1 chunk +12 lines, -0 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 7 chunks +25 lines, -111 lines 0 comments Download
M content/shell/android/javatests/src/org/chromium/content_shell_apk/ContentShellTestBase.java View 1 chunk +2 lines, -3 lines 0 comments Download
D content/test/data/android/input/input_forms.html View 1 chunk +0 lines, -92 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
henrika (OOO until Aug 14)
Created Revert of Add InputConnection-to-JavaScript tests for key input
4 years, 7 months ago (2016-05-03 09:40:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1943233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1943233002/1
4 years, 7 months ago (2016-05-03 09:40:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 09:41:10 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 09:42:36 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1882fb4865d3e8448bd2b62c0c66bf9937696725
Cr-Commit-Position: refs/heads/master@{#391189}

Powered by Google App Engine
This is Rietveld 408576698