Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1943153002: Mozart: Move frame lag compensation to new class. (Closed)

Created:
4 years, 7 months ago by jeffbrown
Modified:
4 years, 7 months ago
Reviewers:
abarth, mikejurka
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Mozart: Move frame lag compensation to new class. Moved code from Choreographer to FrameTracker to allow it to be reused more broadly and without taking a dependency on //base. BUG= R=abarth@google.com Committed: https://chromium.googlesource.com/external/mojo/+/138b200b05c4ce4b1a3cf8f401d43e2b472cba55

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+370 lines, -59 lines) Patch
M mojo/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/services/gfx/composition/cpp/BUILD.gn View 3 chunks +21 lines, -0 lines 0 comments Download
A mojo/services/gfx/composition/cpp/frame_tracker.h View 1 chunk +57 lines, -0 lines 0 comments Download
A mojo/services/gfx/composition/cpp/frame_tracker.cc View 1 chunk +88 lines, -0 lines 0 comments Download
A mojo/services/gfx/composition/cpp/frame_tracker_apptest.cc View 1 chunk +186 lines, -0 lines 0 comments Download
M mojo/services/gfx/composition/interfaces/scheduling.mojom View 1 chunk +6 lines, -0 lines 0 comments Download
M mojo/ui/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/ui/choreographer.h View 4 chunks +6 lines, -5 lines 0 comments Download
M mojo/ui/choreographer.cc View 1 chunk +3 lines, -54 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
jeffbrown
4 years, 7 months ago (2016-05-03 01:01:02 UTC) #2
abarth
lgtm
4 years, 7 months ago (2016-05-03 01:15:18 UTC) #3
jeffbrown
4 years, 7 months ago (2016-05-03 19:50:11 UTC) #5
jeffbrown
4 years, 7 months ago (2016-05-03 19:50:50 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
138b200b05c4ce4b1a3cf8f401d43e2b472cba55 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698