[MD settings] remove unneeded properties

[MD settings] remove unneeded properties

This CL changes the way routing data is handled in the
side nav menu. The page data is now part of the parent
uniformly (and repeated far less often). This should
make this easier to maintain.

BUG=584478
Committed: https://crrev.com/1b341a4d70a0b7a7b31643f8bb83de633fc9e91b
Cr-Commit-Position: refs/heads/master@{#391354}

[dschuyler, 2016-05-03 00:39:24]

Patchset #1 (id:1) has been deleted

[dschuyler, 2016-05-03 00:40:01]

dschuyler@chromium.org changed reviewers:
+ dpapad@chromium.org

[dpapad, 2016-05-03 01:00:02]

Are there any tests for settings-menu? If not, do you think it would be a good
time investment to add some?

https://codereview.chromium.org/1943133002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_menu/settings_menu.html (right):

https://codereview.chromium.org/1943133002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_menu/settings_menu.html:73:
<iron-icon icon="{{arrowState_(basicOpened_)}}" item-icon></iron-icon>
Could this be "[[arrowState_(basicOpened_)]]" instead?

https://codereview.chromium.org/1943133002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_menu/settings_menu.js (right):

https://codereview.chromium.org/1943133002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_menu/settings_menu.js:32:
this.$.advancedPage.opened = this.currentRoute.page == 'advanced';
Did you consider updating those 4 properties via bindings instead?

No need to change, I am just curious because I have faced the same dilemma in
the past (update N properties in a centralized spot  programatically VS spread N
data bindings in HTML).

[dschuyler, 2016-05-03 20:48:53]

https://codereview.chromium.org/1943133002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_menu/settings_menu.html (right):

https://codereview.chromium.org/1943133002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_menu/settings_menu.html:73:
<iron-icon icon="{{arrowState_(basicOpened_)}}" item-icon></iron-icon>
On 2016/05/03 01:00:02, dpapad wrote:
> Could this be "[[arrowState_(basicOpened_)]]" instead?

Done. In separate CL.

https://codereview.chromium.org/1943133002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_menu/settings_menu.js (right):

https://codereview.chromium.org/1943133002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_menu/settings_menu.js:32:
this.$.advancedPage.opened = this.currentRoute.page == 'advanced';
On 2016/05/03 01:00:02, dpapad wrote:
> Did you consider updating those 4 properties via bindings instead?
> 
> No need to change, I am just curious because I have faced the same dilemma in
> the past (update N properties in a centralized spot  programatically VS spread
N
> data bindings in HTML).

Yeah, it's nicer if these are in bound in the html, imo.
The reason for them being here is for URL changes. I.e.
navigating directly to a url such as chrome://md-settings/reset

[dpapad, 2016-05-03 20:59:22]

lgtm

[dschuyler, 2016-05-03 21:04:05]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2016-05-03 21:04:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1943133002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1943133002/20001

[commit-bot: I haz the power, 2016-05-03 21:09:15]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-05-03 21:11:53]

Description was changed from

==========
[MD settings] remove unneeded properties

This CL changes the way routing data is handled in the
side nav menu. The page data is now part of the parent
uniformly (and repeated far less often). This should
make this easier to maintain.

BUG=584478
==========

to

==========
[MD settings] remove unneeded properties

This CL changes the way routing data is handled in the
side nav menu. The page data is now part of the parent
uniformly (and repeated far less often). This should
make this easier to maintain.

BUG=584478

Committed: https://crrev.com/1b341a4d70a0b7a7b31643f8bb83de633fc9e91b
Cr-Commit-Position: refs/heads/master@{#391354}
==========

[commit-bot: I haz the power, 2016-05-03 21:11:54]

Patchset 1 (id:??) landed as
https://crrev.com/1b341a4d70a0b7a7b31643f8bb83de633fc9e91b
Cr-Commit-Position: refs/heads/master@{#391354}