Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 1943053002: Revert "Disable all NEON in BoringSSL if has_broken_neon is set." (Closed)

Created:
4 years, 7 months ago by davidben
Modified:
4 years, 7 months ago
Reviewers:
agl
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Revert "Disable all NEON in BoringSSL if has_broken_neon is set." This reverts commit 396d38c7d55e1c039069017afd74488cac9060cd. The change caused the has_broken_neon to regress because, at the corresponding BoringSSL revision, the getauxval logic would run afterwards and clear the setting. For M50, revert this change to restore the old behavior. Conveniently, the BoringSSL half of this pair (85003903fc58d8825e02162fd33a9b9c28fdec35) rolled into Chromium after the branch point and was later subsumed by moving the check into BoringSSL itself, so trunk and M51 have the correct broken_neon/getauxval interaction. (Though they still regressed the check due to an interation with Chromium setting arm_neon=1. This has since been fixed.) BUG=606629 TBR=agl@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/a4ab48f3dac253ee97295ad2fb17a9fd6cda15ea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M crypto/openssl_util.cc View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
davidben
4 years, 7 months ago (2016-05-02 21:25:30 UTC) #1
davidben
Committed patchset #1 (id:1) manually as a4ab48f3dac253ee97295ad2fb17a9fd6cda15ea (presubmit successful).
4 years, 7 months ago (2016-05-02 21:28:17 UTC) #3
agl
4 years, 7 months ago (2016-05-02 21:37:46 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698