Revert of [NTP Snippets] Add unit tests for NTPSnippetsFetcher

Revert of [NTP Snippets] Add unit tests for NTPSnippetsFetcher (patchset #5 id:80001 of https://codereview.chromium.org/1940843002/ )

Reason for revert:
I think this broke components_unittests on iOS:

https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/builds/38004

Original issue's description:
> [NTP Snippets] Add unit tests for NTPSnippetsFetcher
>
> The class had almost no coverage given that, besides not having unit tests, the ones for NTPSnippetsService don't actually exercise the fetcher.
>
> The proposed tests make use of FakeURLFetcherFactory to exercise basic success and failure cases and verify how callbacks are triggered. FakeURLFetcherFactory doesn't however support verifying features like the uploaded POST data for selected hosts which is left outside the scope of this patch.
>
> BUG=584428
>
> Committed: https://crrev.com/302f9f70265f86097aa3bc4c7695fe99d067b47c
> Cr-Commit-Position: refs/heads/master@{#390950}

TBR=treib@chromium.org,mastiz@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=584428
Committed: https://crrev.com/508d55c0385d65406d2fc9a8235261f649ccf874
Cr-Commit-Position: refs/heads/master@{#390975}

[Dirk Pranke, 2016-05-02 17:08:22]

Created Revert of [NTP Snippets] Add unit tests for NTPSnippetsFetcher

[commit-bot: I haz the power, 2016-05-02 17:08:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1942913002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1942913002/1

[commit-bot: I haz the power, 2016-05-02 17:11:08]

Description was changed from

==========
Revert of [NTP Snippets] Add unit tests for NTPSnippetsFetcher (patchset #5
id:80001 of https://codereview.chromium.org/1940843002/ )

Reason for revert:
I think this broke components_unittests on iOS:

https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/bu...

Original issue's description:
> [NTP Snippets] Add unit tests for NTPSnippetsFetcher
> 
> The class had almost no coverage given that, besides not having unit tests,
the ones for NTPSnippetsService don't actually exercise the fetcher.
> 
> The proposed tests make use of FakeURLFetcherFactory to exercise basic success
and failure cases and verify how callbacks are triggered. FakeURLFetcherFactory
doesn't however support verifying features like the uploaded POST data for
selected hosts which is left outside the scope of this patch.
> 
> BUG=584428
> 
> Committed: https://crrev.com/302f9f70265f86097aa3bc4c7695fe99d067b47c
> Cr-Commit-Position: refs/heads/master@{#390950}

TBR=treib@chromium.org,mastiz@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=584428
==========

to

==========
Revert of [NTP Snippets] Add unit tests for NTPSnippetsFetcher (patchset #5
id:80001 of https://codereview.chromium.org/1940843002/ )

Reason for revert:
I think this broke components_unittests on iOS:

https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/bu...

Original issue's description:
> [NTP Snippets] Add unit tests for NTPSnippetsFetcher
> 
> The class had almost no coverage given that, besides not having unit tests,
the ones for NTPSnippetsService don't actually exercise the fetcher.
> 
> The proposed tests make use of FakeURLFetcherFactory to exercise basic success
and failure cases and verify how callbacks are triggered. FakeURLFetcherFactory
doesn't however support verifying features like the uploaded POST data for
selected hosts which is left outside the scope of this patch.
> 
> BUG=584428
> 
> Committed: https://crrev.com/302f9f70265f86097aa3bc4c7695fe99d067b47c
> Cr-Commit-Position: refs/heads/master@{#390950}

TBR=treib@chromium.org,mastiz@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=584428
==========

[commit-bot: I haz the power, 2016-05-02 17:11:10]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-02 17:12:35]

Description was changed from

==========
Revert of [NTP Snippets] Add unit tests for NTPSnippetsFetcher (patchset #5
id:80001 of https://codereview.chromium.org/1940843002/ )

Reason for revert:
I think this broke components_unittests on iOS:

https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/bu...

Original issue's description:
> [NTP Snippets] Add unit tests for NTPSnippetsFetcher
> 
> The class had almost no coverage given that, besides not having unit tests,
the ones for NTPSnippetsService don't actually exercise the fetcher.
> 
> The proposed tests make use of FakeURLFetcherFactory to exercise basic success
and failure cases and verify how callbacks are triggered. FakeURLFetcherFactory
doesn't however support verifying features like the uploaded POST data for
selected hosts which is left outside the scope of this patch.
> 
> BUG=584428
> 
> Committed: https://crrev.com/302f9f70265f86097aa3bc4c7695fe99d067b47c
> Cr-Commit-Position: refs/heads/master@{#390950}

TBR=treib@chromium.org,mastiz@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=584428
==========

to

==========
Revert of [NTP Snippets] Add unit tests for NTPSnippetsFetcher (patchset #5
id:80001 of https://codereview.chromium.org/1940843002/ )

Reason for revert:
I think this broke components_unittests on iOS:

https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/bu...

Original issue's description:
> [NTP Snippets] Add unit tests for NTPSnippetsFetcher
>
> The class had almost no coverage given that, besides not having unit tests,
the ones for NTPSnippetsService don't actually exercise the fetcher.
>
> The proposed tests make use of FakeURLFetcherFactory to exercise basic success
and failure cases and verify how callbacks are triggered. FakeURLFetcherFactory
doesn't however support verifying features like the uploaded POST data for
selected hosts which is left outside the scope of this patch.
>
> BUG=584428
>
> Committed: https://crrev.com/302f9f70265f86097aa3bc4c7695fe99d067b47c
> Cr-Commit-Position: refs/heads/master@{#390950}

TBR=treib@chromium.org,mastiz@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=584428

Committed: https://crrev.com/508d55c0385d65406d2fc9a8235261f649ccf874
Cr-Commit-Position: refs/heads/master@{#390975}
==========

[commit-bot: I haz the power, 2016-05-02 17:12:36]

Patchset 1 (id:??) landed as
https://crrev.com/508d55c0385d65406d2fc9a8235261f649ccf874
Cr-Commit-Position: refs/heads/master@{#390975}

[mastiz, 2016-05-03 07:32:12]

lgtm