Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1942873002: [wasm] Remove unnecessary kExprNop from WASM_BR and other macros. (Closed)

Created:
4 years, 7 months ago by titzer
Modified:
4 years, 7 months ago
Reviewers:
ahaas, binji
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Remove unnecessary kExprNop from WASM_BR and other macros. R=ahaas@chromium.org,binji@chromium.org BUG= Committed: https://crrev.com/2949e05d1e38a51a6c649e4add898f5356eb3f6c Cr-Commit-Position: refs/heads/master@{#35964}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -12 lines) Patch
M src/wasm/wasm-macro-gen.h View 1 chunk +4 lines, -7 lines 0 comments Download
M test/unittests/wasm/wasm-macro-gen-unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
titzer
4 years, 7 months ago (2016-05-02 16:25:25 UTC) #1
binji
lgtm
4 years, 7 months ago (2016-05-02 17:11:14 UTC) #2
ahaas
lgtm
4 years, 7 months ago (2016-05-03 07:10:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942873002/1
4 years, 7 months ago (2016-05-03 08:15:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 08:18:14 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 08:20:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2949e05d1e38a51a6c649e4add898f5356eb3f6c
Cr-Commit-Position: refs/heads/master@{#35964}

Powered by Google App Engine
This is Rietveld 408576698