media/audio/clockless_audio_sink.h - Issue 1942803002: Caching AudioOutputDevice instances in mixer manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/clockless_audio_sink.h

Issue 1942803002: Caching AudioOutputDevice instances in mixer manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: dalecurtis@'s comments addressed, build issue fixed Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/audio_renderer_sink_cache_unittest.cc ('K') | « content/renderer/render_thread_impl.cc ('k') | media/audio/clockless_audio_sink.cc » ('j') | media/base/audio_renderer_mixer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/audio/clockless_audio_sink.h

diff --git a/media/audio/clockless_audio_sink.h b/media/audio/clockless_audio_sink.h

index 366998947f8a3a0d6db152f55b85b0e61dd11ae3..10c3d39f4e1de265e69f762b1f06f46cdd7ea6c8 100644

--- a/media/audio/clockless_audio_sink.h

+++ b/media/audio/clockless_audio_sink.h

@@ -26,6 +26,7 @@ class MEDIA_EXPORT ClocklessAudioSink

: NON_EXPORTED_BASE(public AudioRendererSink) {

public:

ClocklessAudioSink();

+ explicit ClocklessAudioSink(const OutputDeviceInfo& device_info);

// AudioRendererSink implementation.

void Initialize(const AudioParameters& params,

@@ -50,6 +51,7 @@ class MEDIA_EXPORT ClocklessAudioSink

~ClocklessAudioSink() override;

private:

+ OutputDeviceInfo device_info_;

miu 2016/05/19 22:27:15 const OutputDeviceInfo, please.

o1ka 2016/05/23 16:16:54 Done.

std::unique_ptr<ClocklessAudioSinkThread> thread_;

bool initialized_;

bool playing_;