media/test/pipeline_integration_test_base.h - Issue 1942803002: Caching AudioOutputDevice instances in mixer manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/test/pipeline_integration_test_base.h

Issue 1942803002: Caching AudioOutputDevice instances in mixer manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First round of comments addressed Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/test/pipeline_integration_test_base.h

diff --git a/media/test/pipeline_integration_test_base.h b/media/test/pipeline_integration_test_base.h

index f23eace2c1b86a796e2435e9d88c520baa545518..0b837c58c9fa57d49e0f315e8ad2d751ccf4a4bf 100644

--- a/media/test/pipeline_integration_test_base.h

+++ b/media/test/pipeline_integration_test_base.h

@@ -12,7 +12,6 @@

#include "base/message_loop/message_loop.h"

#include "media/audio/clockless_audio_sink.h"

#include "media/audio/null_audio_sink.h"

-#include "media/base/audio_hardware_config.h"

#include "media/base/demuxer.h"

#include "media/base/media_keys.h"

#include "media/base/null_video_sink.h"

@@ -133,7 +132,6 @@ class PipelineIntegrationTestBase : public Pipeline::Client {

VideoPixelFormat last_video_frame_format_;

ColorSpace last_video_frame_color_space_;

DummyTickClock dummy_clock_;

- AudioHardwareConfig hardware_config_;

PipelineMetadata metadata_;

PipelineStatus StartInternal(std::unique_ptr<DataSource> data_source,

« media/base/audio_renderer_mixer.cc ('K') | « media/renderers/default_renderer_factory.cc ('k') | media/test/pipeline_integration_test_base.cc » ('j') | no next file with comments »