Caching AudioOutputDevice instances in mixer manager

media/base/audio_renderer_mixer_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // MSVC++ requires this to be set before any other includes to get M_PI.
 #define _USE_MATH_DEFINES
 
 #include "media/base/audio_renderer_mixer.h"
 
 #include <stddef.h>
@@ skipping 54 matching lines @@
 
     // Create output parameters based on test parameters.
     output_parameters_ = AudioParameters(
         AudioParameters::AUDIO_PCM_LOW_LATENCY, kChannelLayout,
         std::tr1::get<2>(GetParam()), 16, kLowLatencyBufferSize);
 
     sink_ = new MockAudioRendererSink();
     EXPECT_CALL(*sink_.get(), Start());
     EXPECT_CALL(*sink_.get(), Stop());
 
-    mixer_.reset(new AudioRendererMixer(output_parameters_, sink_));
+    mixer_.reset(
+        new AudioRendererMixer(output_parameters_, sink_.get(),
+                               base::Bind(&AudioRendererMixerTest::ReleaseSink,
+                                          base::Unretained(this))));
     mixer_callback_ = sink_->callback();
 
     audio_bus_ = AudioBus::Create(output_parameters_);
     expected_audio_bus_ = AudioBus::Create(output_parameters_);
 
     // Allocate one callback for generating expected results.
     double step = kSineCycles / static_cast<double>(
         output_parameters_.frames_per_buffer());
     expected_callback_.reset(new FakeAudioRenderCallback(step));
   }
 
   AudioRendererMixer* GetMixer(const AudioParameters& params,
                                const std::string& device_id,
                                const url::Origin& security_origin,
                                OutputDeviceStatus* device_status) {
     return mixer_.get();
   }
 
   MOCK_METHOD3(RemoveMixer,
                void(const AudioParameters&,
                     const std::string&,
                     const url::Origin&));
 
+  MOCK_METHOD2(GetOutputDeviceInfo,
+               OutputDeviceInfo(const std::string&, const url::Origin&));
+
+  MOCK_METHOD1(ReleaseSink, void(AudioRendererSink*));
+
   void InitializeInputs(int inputs_per_sample_rate) {
     mixer_inputs_.reserve(inputs_per_sample_rate * input_parameters_.size());
     fake_callbacks_.reserve(inputs_per_sample_rate * input_parameters_.size());
 
     for (size_t i = 0, input = 0; i < input_parameters_.size(); ++i) {
       // Setup FakeAudioRenderCallback step to compensate for resampling.
       double scale_factor =
           input_parameters_[i].sample_rate() /
           static_cast<double>(output_parameters_.sample_rate());
       double step =
           kSineCycles /
           (scale_factor *
            static_cast<double>(output_parameters_.frames_per_buffer()));
 
       for (int j = 0; j < inputs_per_sample_rate; ++j, ++input) {
         fake_callbacks_.push_back(new FakeAudioRenderCallback(step));
-        mixer_inputs_.push_back(new AudioRendererMixerInput(
-            base::Bind(&AudioRendererMixerTest::GetMixer,
-                       base::Unretained(this)),
-            base::Bind(&AudioRendererMixerTest::RemoveMixer,
-                       base::Unretained(this)),
-            // Default device ID and security origin.
-            std::string(), url::Origin()));
+        mixer_inputs_.push_back(CreateMixerInput());
         mixer_inputs_[input]->Initialize(input_parameters_[i],
                                          fake_callbacks_[input]);
         mixer_inputs_[input]->SetVolume(1.0f);
       }
     }
     EXPECT_CALL(*this, RemoveMixer(testing::_, testing::_, testing::_))
         .Times(mixer_inputs_.size());
   }
 
   bool ValidateAudioData(int index, int frames, float scale, double epsilon) {
@@ skipping 190 matching lines @@
     if (mixer_inputs_.size() % 2)
       mixer_inputs_[mixer_inputs_.size() - 1]->Stop();
 
     ASSERT_TRUE(RenderAndValidateAudioData(
         std::max(1.f, static_cast<float>(floor(mixer_inputs_.size() / 2.f)))));
 
     for (size_t i = 1; i < mixer_inputs_.size(); i += 2)
       mixer_inputs_[i]->Stop();
   }
 
+  scoped_refptr<AudioRendererMixerInput> CreateMixerInput() {
+    return new AudioRendererMixerInput(
+        base::Bind(&AudioRendererMixerTest::GetMixer, base::Unretained(this)),
+        base::Bind(&AudioRendererMixerTest::RemoveMixer,
+                   base::Unretained(this)),
+        base::Bind(&AudioRendererMixerTest::GetOutputDeviceInfo,
+                   base::Unretained(this)),
+        // Default device ID and security origin.
+        std::string(), url::Origin());
+  }
+
  protected:
   virtual ~AudioRendererMixerTest() {}
 
   scoped_refptr<MockAudioRendererSink> sink_;
   std::unique_ptr<AudioRendererMixer> mixer_;
   AudioRendererSink::RenderCallback* mixer_callback_;
   std::vector<AudioParameters> input_parameters_;
   AudioParameters output_parameters_;
   std::unique_ptr<AudioBus> audio_bus_;
   std::unique_ptr<AudioBus> expected_audio_bus_;
@@ skipping 117 matching lines @@
 
   for (size_t i = 0; i < mixer_inputs_.size(); ++i)
     mixer_inputs_[i]->Stop();
 }
 
 // Ensure constructing an AudioRendererMixerInput, but not initializing it does
 // not call RemoveMixer().
 TEST_P(AudioRendererMixerBehavioralTest, NoInitialize) {
   EXPECT_CALL(*this, RemoveMixer(testing::_, testing::_, testing::_)).Times(0);
   scoped_refptr<AudioRendererMixerInput> audio_renderer_mixer_input =
-      new AudioRendererMixerInput(
-          base::Bind(&AudioRendererMixerTest::GetMixer, base::Unretained(this)),
-          base::Bind(&AudioRendererMixerTest::RemoveMixer,
-                     base::Unretained(this)),
-          // Default device ID and security origin.
-          std::string(), url::Origin());
+      CreateMixerInput();
 }
 
 // Ensure the physical stream is paused after a certain amount of time with no
 // inputs playing.  The test will hang if the behavior is incorrect.
 TEST_P(AudioRendererMixerBehavioralTest, MixerPausesStream) {
   const base::TimeDelta kPauseTime = base::TimeDelta::FromMilliseconds(500);
   // This value can't be too low or valgrind, tsan will timeout on the bots.
   const base::TimeDelta kTestTimeout = 10 * kPauseTime;
   mixer_->set_pause_delay_for_testing(kPauseTime);
 
@@ skipping 66 matching lines @@
 INSTANTIATE_TEST_CASE_P(
     AudioRendererMixerBehavioralTest,
     AudioRendererMixerBehavioralTest,
     testing::ValuesIn(std::vector<AudioRendererMixerTestData>(
         1,
         std::tr1::make_tuple(&kTestInputLower,
                              1,
                              kTestInputLower,
                              0.00000048))));
 }  // namespace media