Caching AudioOutputDevice instances in mixer manager

media/base/audio_renderer_mixer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_BASE_AUDIO_RENDERER_MIXER_H_
 #define MEDIA_BASE_AUDIO_RENDERER_MIXER_H_
 
 #include <stdint.h>
 
 #include <map>
 #include <memory>
 #include <string>
 
 #include "base/macros.h"
 #include "base/synchronization/lock.h"
 #include "base/time/time.h"
 #include "media/base/audio_converter.h"
 #include "media/base/audio_renderer_sink.h"
 #include "media/base/loopback_audio_converter.h"
 
 namespace media {
 
 // Mixes a set of AudioConverter::InputCallbacks into a single output stream
 // which is funneled into a single shared AudioRendererSink; saving a bundle
 // on renderer side resources.
 class MEDIA_EXPORT AudioRendererMixer
     : NON_EXPORTED_BASE(public AudioRendererSink::RenderCallback) {
  public:
+  typedef base::Callback<void(AudioRendererSink* sink)> ReleaseSinkCallback;
+
   AudioRendererMixer(const AudioParameters& output_params,
-                     const scoped_refptr<AudioRendererSink>& sink);
+                     AudioRendererSink* sink,
+                     const ReleaseSinkCallback& release_sink_cb);
   ~AudioRendererMixer() override;
 
   // Add or remove a mixer input from mixing; called by AudioRendererMixerInput.
   void AddMixerInput(const AudioParameters& input_params,
                      AudioConverter::InputCallback* input);
   void RemoveMixerInput(const AudioParameters& input_params,
                         AudioConverter::InputCallback* input);
 
   // Since errors may occur even when no inputs are playing, an error callback
   // must be registered separately from adding a mixer input.  The same callback
@@ skipping 16 matching lines @@
   int Render(AudioBus* audio_bus,
              uint32_t frames_delayed,
              uint32_t frames_skipped) override;
   void OnRenderError() override;
 
   bool is_master_sample_rate(int sample_rate) {
     return sample_rate == output_params_.sample_rate();
   }
 
   // Output sink for this mixer.
-  scoped_refptr<AudioRendererSink> audio_sink_;
+  AudioRendererSink* audio_sink_;

[miu, 2016/05/12 21:53:06]

Please make this const: AudioRendererSink* const audio_sink_;

[o1ka, 2016/05/17 17:17:24]

Done.

+
+  // Callback to release the sink on mixer destruction.
+  const ReleaseSinkCallback release_sink_cb_;
 
   // Output parameters for this mixer.
   AudioParameters output_params_;
 
   // ---------------[ All variables below protected by |lock_| ]---------------
   base::Lock lock_;
 
   // List of error callbacks used by this mixer.
   typedef std::list<base::Closure> ErrorCallbackList;
   ErrorCallbackList error_callbacks_;
@@ skipping 12 matching lines @@
   base::TimeDelta pause_delay_;
   base::TimeTicks last_play_time_;
   bool playing_;
 
   DISALLOW_COPY_AND_ASSIGN(AudioRendererMixer);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_BASE_AUDIO_RENDERER_MIXER_H_