Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1942763002: Rebased and retested version of CL 1915123008. (Closed)

Created:
4 years, 7 months ago by eernst
Modified:
4 years, 7 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, floitsch
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rebased and retested version of CL 1915123008. This CL is a rebased and retested version of CL 1915123008, 'Implements support for ignoring method type arguments in resolution'. That CL caused failures on dart2js-jsshell but it is now confirmed that the failures were caused by another CL. Committed: https://github.com/dart-lang/sdk/commit/33478e2ab52b41b7849406c1789ca4e14438dcda

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+265 lines, -94 lines) Patch
M pkg/compiler/lib/src/dart_backend/backend_ast_to_frontend_ast.dart View 4 chunks +8 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 8 chunks +26 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 9 chunks +26 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/parser/node_listener.dart View 5 chunks +13 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/resolution/enum_creator.dart View 3 chunks +5 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 8 chunks +24 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/scope.dart View 3 chunks +24 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/resolution/signatures.dart View 7 chunks +50 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/resolution/type_resolver.dart View 2 chunks +7 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/typedefs.dart View 1 chunk +7 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 3 chunks +9 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/tree/nodes.dart View 5 chunks +14 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 4 chunks +22 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 6 chunks +26 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
eernst
TBD: Same CL as https://codereview.chromium.org/1915123008/ which was reverted Friday evening: It is now known that ...
4 years, 7 months ago (2016-05-02 09:50:00 UTC) #2
eernst
4 years, 7 months ago (2016-05-02 09:50:16 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
33478e2ab52b41b7849406c1789ca4e14438dcda (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698