third_party/WebKit/Source/core/svg/SVGElement.h - Issue 1942723004: Change EventTarget callback APIs for add/RemoveEventListenerInternal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGElement.h

Issue 1942723004: Change EventTarget callback APIs for add/RemoveEventListenerInternal. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix gypi Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/events/EventTarget.h ('K') | « third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp ('k') | third_party/WebKit/Source/core/svg/SVGElement.cpp » ('j') | third_party/WebKit/Source/core/svg/SVGElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/SVGElement.h

diff --git a/third_party/WebKit/Source/core/svg/SVGElement.h b/third_party/WebKit/Source/core/svg/SVGElement.h

index d4094f2c93880001d3dde5f6f82f6a319a7345bf..b511d43c95b3027892fb7eb535ee8475594af5b8 100644

--- a/third_party/WebKit/Source/core/svg/SVGElement.h

+++ b/third_party/WebKit/Source/core/svg/SVGElement.h

@@ -223,7 +223,7 @@ protected:

bool hasFocusEventListeners() const;

bool addEventListenerInternal(const AtomicString& eventType, EventListener*, const EventListenerOptions&) final;

- bool removeEventListenerInternal(const AtomicString& eventType, EventListener*, const EventListenerOptions&) final;

+ bool removeEventListenerInternal(const AtomicString& eventType, const EventListener*, const EventListenerOptions&) final;

private:

bool isSVGElement() const = delete; // This will catch anyone doing an unnecessary check.