third_party/WebKit/Source/core/svg/SVGElement.cpp - Issue 1942723004: Change EventTarget callback APIs for add/RemoveEventListenerInternal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGElement.cpp

Issue 1942723004: Change EventTarget callback APIs for add/RemoveEventListenerInternal. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix gypi Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/events/EventTarget.h ('K') | « third_party/WebKit/Source/core/svg/SVGElement.h ('k') | third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h » ('j') | third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/SVGElement.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGElement.cpp b/third_party/WebKit/Source/core/svg/SVGElement.cpp

index 984539f47bcc5bd9cb86ce58dddaacd2e0207bfc..37a37e0ad1a7a82b31d576e1a4710d956d3b71cc 100644

--- a/third_party/WebKit/Source/core/svg/SVGElement.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGElement.cpp

@@ -748,7 +748,7 @@ bool SVGElement::addEventListenerInternal(const AtomicString& eventType, EventLi

return true;

}

-bool SVGElement::removeEventListenerInternal(const AtomicString& eventType, EventListener* listener, const EventListenerOptions& options)

+bool SVGElement::removeEventListenerInternal(const AtomicString& eventType, const EventListener* listener, const EventListenerOptions& options)

{

// Remove event listener from regular DOM element

if (!Node::removeEventListenerInternal(eventType, listener, options))

@@ -776,7 +776,7 @@ static bool hasLoadListener(Element* element)

if (!entry)

continue;

for (size_t i = 0; i < entry->size(); ++i) {

- if (entry->at(i).useCapture)

+ if (entry->at(i).capture())

return true;

}