third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp - Issue 1942723004: Change EventTarget callback APIs for add/RemoveEventListenerInternal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

Issue 1942723004: Change EventTarget callback APIs for add/RemoveEventListenerInternal. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix win32 signed/unsigned issue Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/presentation/PresentationConnection.h ('k') | third_party/WebKit/Source/modules/presentation/PresentationRequest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

diff --git a/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp b/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

index a2f0dfafec224b09ba01d4034c3f2536cde40caf..44f812985432c570fbdfa19ffe423d5b6d8eb051 100644

--- a/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

+++ b/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

@@ -214,8 +214,9 @@ ExecutionContext* PresentationConnection::getExecutionContext() const

return frame()->document();

}

-bool PresentationConnection::addEventListenerInternal(const AtomicString& eventType, EventListener* listener, const EventListenerOptions& options)

+void PresentationConnection::addedEventListener(const AtomicString& eventType, RegisteredEventListener& registeredListener)

{

+ EventTargetWithInlineData::addedEventListener(eventType, registeredListener);

if (eventType == EventTypeNames::connect)

UseCounter::count(getExecutionContext(), UseCounter::PresentationConnectionConnectEventListener);

else if (eventType == EventTypeNames::close)

@@ -224,8 +225,6 @@ bool PresentationConnection::addEventListenerInternal(const AtomicString& eventT

UseCounter::count(getExecutionContext(), UseCounter::PresentationConnectionTerminateEventListener);

else if (eventType == EventTypeNames::message)

UseCounter::count(getExecutionContext(), UseCounter::PresentationConnectionMessageEventListener);

- return EventTarget::addEventListenerInternal(eventType, listener, options);

}

DEFINE_TRACE(PresentationConnection)