Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Unified Diff: third_party/WebKit/Source/modules/mediastream/MediaDevices.cpp

Issue 1942723004: Change EventTarget callback APIs for add/RemoveEventListenerInternal. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix win32 signed/unsigned issue Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/mediastream/MediaDevices.cpp
diff --git a/third_party/WebKit/Source/modules/mediastream/MediaDevices.cpp b/third_party/WebKit/Source/modules/mediastream/MediaDevices.cpp
index 218a50cd876cebd6df3dbf6c2fc70dc6bee935c0..8fc9b27d8d872f2b3937411a67351af67b4ad9e3 100644
--- a/third_party/WebKit/Source/modules/mediastream/MediaDevices.cpp
+++ b/third_party/WebKit/Source/modules/mediastream/MediaDevices.cpp
@@ -169,21 +169,17 @@ void MediaDevices::removeAllEventListeners()
stopObserving();
}
-bool MediaDevices::addEventListenerInternal(const AtomicString& eventType, EventListener* listener, const EventListenerOptions& options)
+void MediaDevices::addedEventListener(const AtomicString& eventType, RegisteredEventListener& registeredListener)
{
- if (!EventTargetWithInlineData::addEventListenerInternal(eventType, listener, options))
- return false;
+ EventTargetWithInlineData::addedEventListener(eventType, registeredListener);
startObserving();
- return true;
}
-bool MediaDevices::removeEventListenerInternal(const AtomicString& eventType, EventListener* listener, const EventListenerOptions& options)
+void MediaDevices::removedEventListener(const AtomicString& eventType, const RegisteredEventListener& registeredListener)
{
- if (!EventTargetWithInlineData::removeEventListenerInternal(eventType, listener, options))
- return false;
+ EventTargetWithInlineData::removedEventListener(eventType, registeredListener);
if (!hasEventListeners())
stopObserving();
- return true;
}
bool MediaDevices::hasPendingActivity() const

Powered by Google App Engine
This is Rietveld 408576698