Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

Issue 1942723004: Change EventTarget callback APIs for add/RemoveEventListenerInternal. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix win32 signed/unsigned issue Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
diff --git a/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
index 018ad380a91228ac514394c68c6297dacf0074ee..acb4cfcd292594344964e315ca59425eaed2fd62 100644
--- a/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
+++ b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
@@ -1329,17 +1329,14 @@ CustomElementsRegistry* LocalDOMWindow::customElements() const
return m_customElements.get();
}
-bool LocalDOMWindow::addEventListenerInternal(const AtomicString& eventType, EventListener* listener, const EventListenerOptions& options)
+void LocalDOMWindow::addedEventListener(const AtomicString& eventType, RegisteredEventListener& registeredListener)
{
- if (!EventTarget::addEventListenerInternal(eventType, listener, options))
- return false;
-
+ DOMWindow::addedEventListener(eventType, registeredListener);
if (frame() && frame()->host())
- frame()->host()->eventHandlerRegistry().didAddEventHandler(*this, eventType, options);
+ frame()->host()->eventHandlerRegistry().didAddEventHandler(*this, eventType, registeredListener.options());
- if (Document* document = this->document()) {
+ if (Document* document = this->document())
document->addListenerTypeIfNeeded(eventType);
- }
notifyAddEventListener(this, eventType);
@@ -1358,17 +1355,13 @@ bool LocalDOMWindow::addEventListenerInternal(const AtomicString& eventType, Eve
UseCounter::count(document(), UseCounter::SubFrameBeforeUnloadRegistered);
}
}
-
- return true;
}
-bool LocalDOMWindow::removeEventListenerInternal(const AtomicString& eventType, EventListener* listener, const EventListenerOptions& options)
+void LocalDOMWindow::removedEventListener(const AtomicString& eventType, const RegisteredEventListener& registeredListener)
{
- if (!EventTarget::removeEventListenerInternal(eventType, listener, options))
- return false;
-
+ DOMWindow::removedEventListener(eventType, registeredListener);
if (frame() && frame()->host())
- frame()->host()->eventHandlerRegistry().didRemoveEventHandler(*this, eventType, options);
+ frame()->host()->eventHandlerRegistry().didRemoveEventHandler(*this, eventType, registeredListener.options());
notifyRemoveEventListener(this, eventType);
@@ -1377,8 +1370,6 @@ bool LocalDOMWindow::removeEventListenerInternal(const AtomicString& eventType,
} else if (eventType == EventTypeNames::beforeunload && allowsBeforeUnloadListeners(this)) {
removeBeforeUnloadEventListener(this);
}
-
- return true;
}
void LocalDOMWindow::dispatchLoadEvent()

Powered by Google App Engine
This is Rietveld 408576698