Change EventTarget callback APIs for add/RemoveEventListenerInternal.

third_party/WebKit/Source/core/events/EventTarget.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  *           (C) 2007, 2008 Nikolas Zimmermann <zimmermann@kde.org>
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ skipping 99 matching lines @@
     virtual Node* toNode();
     virtual const DOMWindow* toDOMWindow() const;
     virtual const LocalDOMWindow* toLocalDOMWindow() const;
     virtual LocalDOMWindow* toLocalDOMWindow();
     virtual MessagePort* toMessagePort();
 
     bool addEventListener(const AtomicString& eventType, EventListener*, bool useCapture = false);
     bool addEventListener(const AtomicString& eventType, EventListener*, const EventListenerOptionsOrBoolean&);
     bool addEventListener(const AtomicString& eventType, EventListener*, EventListenerOptions&);
 
-    bool removeEventListener(const AtomicString& eventType, EventListener*, bool useCapture = false);
-    bool removeEventListener(const AtomicString& eventType, EventListener*, const EventListenerOptionsOrBoolean&);
-    bool removeEventListener(const AtomicString& eventType, EventListener*, EventListenerOptions&);
+    bool removeEventListener(const AtomicString& eventType, const EventListener*, bool useCapture = false);
+    bool removeEventListener(const AtomicString& eventType, const EventListener*, const EventListenerOptionsOrBoolean&);
+    bool removeEventListener(const AtomicString& eventType, const EventListener*, EventListenerOptions&);
     virtual void removeAllEventListeners();
 
     DispatchEventResult dispatchEvent(Event*);
 
     // dispatchEventForBindings is intended to only be called from
     // javascript originated calls. This method will validate and may adjust
     // the Event object before dispatching.
     bool dispatchEventForBindings(Event*, ExceptionState&);
     virtual void uncaughtExceptionInEventHandler();
 
@@ skipping 12 matching lines @@
     static DispatchEventResult dispatchEventResult(const Event&);
 
     DEFINE_INLINE_VIRTUAL_TRACE() { }
 
     virtual bool keepEventInNode(Event*) { return false; }
 
 protected:
     EventTarget();
 
     virtual bool addEventListenerInternal(const AtomicString& eventType, EventListener*, const EventListenerOptions&);
-    virtual bool removeEventListenerInternal(const AtomicString& eventType, EventListener*, const EventListenerOptions&);
+    virtual bool removeEventListenerInternal(const AtomicString& eventType, const EventListener*, const EventListenerOptions&);
+    virtual void addedEventListener(const AtomicString& eventType, const RegisteredEventListener&);

[bokan, 2016/05/03 15:52:46]

Please add comments describing what these are for.

[dtapuska, 2016/05/03 20:53:04]

Done.

+    virtual void removedEventListener(const AtomicString& eventType, const RegisteredEventListener&);
     virtual DispatchEventResult dispatchEventInternal(Event*);
 
     // Subclasses should likely not override these themselves; instead, they should subclass EventTargetWithInlineData.
     virtual EventTargetData* eventTargetData() = 0;
     virtual EventTargetData& ensureEventTargetData() = 0;
 
 private:
     LocalDOMWindow* executingWindow();
     void fireEventListeners(Event*, EventTargetData*, EventListenerVector&);
     void countLegacyEvents(const AtomicString& legacyTypeName, EventListenerVector*, EventListenerVector*);
@@ skipping 77 matching lines @@
 {
     EventTargetData* d = eventTargetData();
     if (!d)
         return false;
     return d->eventListenerMap.containsCapturing(eventType);
 }
 
 } // namespace blink
 
 #endif // EventTarget_h