Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGElement.h

Issue 1942723004: Change EventTarget callback APIs for add/RemoveEventListenerInternal. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix win32 signed/unsigned issue Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>
4 * Copyright (C) 2009, 2014 Apple Inc. All rights reserved. 4 * Copyright (C) 2009, 2014 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 204 matching lines...) Expand 10 before | Expand all | Expand 10 after
215 { 215 {
216 ASSERT(m_SVGRareData); 216 ASSERT(m_SVGRareData);
217 return m_SVGRareData.get(); 217 return m_SVGRareData.get();
218 } 218 }
219 219
220 // SVGFitToViewBox::parseAttribute uses reportAttributeParsingError. 220 // SVGFitToViewBox::parseAttribute uses reportAttributeParsingError.
221 friend class SVGFitToViewBox; 221 friend class SVGFitToViewBox;
222 void reportAttributeParsingError(SVGParsingError, const QualifiedName&, cons t AtomicString&); 222 void reportAttributeParsingError(SVGParsingError, const QualifiedName&, cons t AtomicString&);
223 bool hasFocusEventListeners() const; 223 bool hasFocusEventListeners() const;
224 224
225 bool addEventListenerInternal(const AtomicString& eventType, EventListener*, const EventListenerOptions&) final; 225 void addedEventListener(const AtomicString& eventType, RegisteredEventListen er&) final;
226 bool removeEventListenerInternal(const AtomicString& eventType, EventListene r*, const EventListenerOptions&) final; 226 void removedEventListener(const AtomicString& eventType, const RegisteredEve ntListener&) final;
227 227
228 private: 228 private:
229 bool isSVGElement() const = delete; // This will catch anyone doing an unnec essary check. 229 bool isSVGElement() const = delete; // This will catch anyone doing an unnec essary check.
230 bool isStyledElement() const = delete; // This will catch anyone doing an un necessary check. 230 bool isStyledElement() const = delete; // This will catch anyone doing an un necessary check.
231 231
232 const ComputedStyle* ensureComputedStyle(PseudoId = PseudoIdNone); 232 const ComputedStyle* ensureComputedStyle(PseudoId = PseudoIdNone);
233 const ComputedStyle* virtualEnsureComputedStyle(PseudoId pseudoElementSpecif ier = PseudoIdNone) final { return ensureComputedStyle(pseudoElementSpecifier); } 233 const ComputedStyle* virtualEnsureComputedStyle(PseudoId pseudoElementSpecif ier = PseudoIdNone) final { return ensureComputedStyle(pseudoElementSpecifier); }
234 void willRecalcStyle(StyleRecalcChange) override; 234 void willRecalcStyle(StyleRecalcChange) override;
235 235
236 void buildPendingResourcesIfNeeded(); 236 void buildPendingResourcesIfNeeded();
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
281 template<typename T> inline bool is##thisType(const T* node) { return is##th isType(node); } \ 281 template<typename T> inline bool is##thisType(const T* node) { return is##th isType(node); } \
282 template<typename T> inline bool is##thisType(const Member<T>& node) { retur n is##thisType(node.get()); } \ 282 template<typename T> inline bool is##thisType(const Member<T>& node) { retur n is##thisType(node.get()); } \
283 template <> inline bool isElementOfType<const thisType>(const SVGElement& el ement) { return is##thisType(element); } \ 283 template <> inline bool isElementOfType<const thisType>(const SVGElement& el ement) { return is##thisType(element); } \
284 DEFINE_ELEMENT_TYPE_CASTS_WITH_FUNCTION(thisType) 284 DEFINE_ELEMENT_TYPE_CASTS_WITH_FUNCTION(thisType)
285 285
286 } // namespace blink 286 } // namespace blink
287 287
288 #include "core/SVGElementTypeHelpers.h" 288 #include "core/SVGElementTypeHelpers.h"
289 289
290 #endif // SVGElement_h 290 #endif // SVGElement_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698