Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1942723003:
gpu: consolidate id_type_traits.h and gpu_command_buffer_traits* (Closed)
|
Created:
4 years, 7 months ago by Fady Samuel Modified:
4 years, 7 months ago CC:
chromium-reviews, piman+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptiongpu: consolidate id_type_traits.h and gpu_command_buffer_traits*
BUG=607904
TBR=piman@chromium.org for command_buffer_traits.gypi
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/9589e6383f63504c3e5f6545160beb9ca69984ee
Cr-Commit-Position: refs/heads/master@{#391124}
Patch Set 1 #Patch Set 2 : Remove a bad GPU_EXPORT #
Messages
Total messages: 35 (18 generated)
Description was changed from ========== gpu: consolidate id_type_traits.h and gpu_command_buffer_traits* BUG=607904 ========== to ========== gpu: consolidate id_type_traits.h and gpu_command_buffer_traits* BUG=607904 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942723003/1
fsamuel@chromium.org changed reviewers: + jbauman@chromium.org, tsepez@chromium.org
+jbauman@ for gpu/command_buffer. +tsepez@ for ipc (just moving code).
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_optional_gpu_tests_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)
lgtm
The CQ bit was checked by fsamuel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942723003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== gpu: consolidate id_type_traits.h and gpu_command_buffer_traits* BUG=607904 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== gpu: consolidate id_type_traits.h and gpu_command_buffer_traits* BUG=607904 TBR=piman@chromium.org for command_buffer_traits.gypi CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by fsamuel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942723003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_optional_gpu_tests_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)
The CQ bit was checked by fsamuel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942723003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_optional_gpu_tests_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)
The CQ bit was checked by fsamuel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942723003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_optional_gpu_tests_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)
The CQ bit was checked by fsamuel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942723003/1
The CQ bit was checked by fsamuel@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org, jbauman@chromium.org Link to the patchset: https://codereview.chromium.org/1942723003/#ps20001 (title: "Remove a bad GPU_EXPORT")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942723003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942723003/20001
Message was sent while issue was closed.
Description was changed from ========== gpu: consolidate id_type_traits.h and gpu_command_buffer_traits* BUG=607904 TBR=piman@chromium.org for command_buffer_traits.gypi CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== gpu: consolidate id_type_traits.h and gpu_command_buffer_traits* BUG=607904 TBR=piman@chromium.org for command_buffer_traits.gypi CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== gpu: consolidate id_type_traits.h and gpu_command_buffer_traits* BUG=607904 TBR=piman@chromium.org for command_buffer_traits.gypi CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== gpu: consolidate id_type_traits.h and gpu_command_buffer_traits* BUG=607904 TBR=piman@chromium.org for command_buffer_traits.gypi CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/9589e6383f63504c3e5f6545160beb9ca69984ee Cr-Commit-Position: refs/heads/master@{#391124} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/9589e6383f63504c3e5f6545160beb9ca69984ee Cr-Commit-Position: refs/heads/master@{#391124} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
