Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 1942723002: CREDENTIAL: Tighten the behavior of 'requireUserMediation()' (Closed)

Created:
4 years, 7 months ago by vabr (Chromium)
Modified:
4 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, gcasto+watchlist_chromium.org, jam, mkwst+watchlist-passwords_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

CREDENTIAL: Tighten the behavior of 'requireUserMediation()' Currently, we're looking for an exact origin match between a stored PasswordForm and the page which called 'requireUserMediation()'. We ought to be looking for a match between their registrable domains, given that we allow credentials to flow ~freely between these origins. This patch tightens the check accordingly. BUG=607858 R=vabr@chromium.org Review-Url: https://codereview.chromium.org/1928323002 Cr-Commit-Position: refs/heads/master@{#390618} (cherry picked from commit 3aa4344859e35071117a4278663eecf4f3ea9d17) Committed: https://chromium.googlesource.com/chromium/src/+/fe25aa3b45a73b0fe824a0657dba755195d44e39

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -6 lines) Patch
M components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc View 4 chunks +16 lines, -2 lines 0 comments Download
M components/password_manager/core/browser/credential_manager_pending_require_user_mediation_task.h View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/credential_manager_pending_require_user_mediation_task.cc View 3 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
vabr (Chromium)
Hi Mike, This is your https://codereview.chromium.org/1928323002 being berged to 2704. I manually merged the unittest, ...
4 years, 7 months ago (2016-05-02 09:18:55 UTC) #2
Mike West
Thank you, LGTM.
4 years, 7 months ago (2016-05-02 09:19:39 UTC) #3
vabr (Chromium)
4 years, 7 months ago (2016-05-02 09:21:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fe25aa3b45a73b0fe824a0657dba755195d44e39.

Powered by Google App Engine
This is Rietveld 408576698