[chrome.displaySource][WiFi Display] Consider video encoder capabilities

[chrome.displaySource][WiFi Display] Consider video encoder capabilities

Implementation considers the video encoder capabilities during video
formats negotiations with sink and picks the best video encoder profile
from the supported ones.

BUG=242107
Committed: https://crrev.com/869826b7522e495b6104f169cdf64e5ccfc15350
Cr-Commit-Position: refs/heads/master@{#390918}

[Mikhail, 2016-05-02 07:24:34]

mikhail.pozdnyakov@intel.com changed reviewers:
+ alexander.shalamov@intel.com, eero.hakkinen@intel.com

[Mikhail, 2016-05-02 07:24:34]

PTAL

[shalamov, 2016-05-02 07:51:09]

https://codereview.chromium.org/1942713002/diff/1/extensions/renderer/api/dis...
File
extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.cc
(right):

https://codereview.chromium.org/1942713002/diff/1/extensions/renderer/api/dis...
extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.cc:38:
for (const auto& supported : profiles) {

Why to fallback to SW encoder right away? I think that even HW accelerated
constrained baseline profile would be better than SW encoder.

Also, maybe check that profile is in range of media::H264PROFILE_MIN
media::H264PROFILE_MAX and if that check fails, fallback to CBP SW encoder?

[Mikhail, 2016-05-02 08:03:10]

On 2016/05/02 07:51:09, shalamov wrote:
>
https://codereview.chromium.org/1942713002/diff/1/extensions/renderer/api/dis...
> File
>
extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.cc
> (right):
> 
>
https://codereview.chromium.org/1942713002/diff/1/extensions/renderer/api/dis...
>
extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.cc:38:
> for (const auto& supported : profiles) {
> 
> Why to fallback to SW encoder right away? I think that even HW accelerated
> constrained baseline profile would be better than SW encoder.
> 
> Also, maybe check that profile is in range of media::H264PROFILE_MIN
> media::H264PROFILE_MAX and if that check fails, fallback to CBP SW encoder?

This is just to pick the profile for cap negotiations (to notify sink), media
pipeline will anyway try to create accelerated encoder first and then fall back
to the software encoder.

[Mikhail, 2016-05-02 08:04:31]

Patchset #1 (id:1) has been deleted

[shalamov, 2016-05-02 11:19:15]

On 2016/05/02 08:03:10, Mikhail wrote:
> On 2016/05/02 07:51:09, shalamov wrote:
> >
>
https://codereview.chromium.org/1942713002/diff/1/extensions/renderer/api/dis...
> > File
> >
>
extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.cc
> > (right):
> > 
> >
>
https://codereview.chromium.org/1942713002/diff/1/extensions/renderer/api/dis...
> >
>
extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.cc:38:
> > for (const auto& supported : profiles) {
> > 
> > Why to fallback to SW encoder right away? I think that even HW accelerated
> > constrained baseline profile would be better than SW encoder.
> > 
> > Also, maybe check that profile is in range of media::H264PROFILE_MIN
> > media::H264PROFILE_MAX and if that check fails, fallback to CBP SW encoder?
> 
> This is just to pick the profile for cap negotiations (to notify sink), media
> pipeline will anyway try to create accelerated encoder first and then fall
back
> to the software encoder.

lgtm

Thanks for explanation, for cap negotiation this should be sufficient.

[Mikhail, 2016-05-02 11:23:31]

The CQ bit was checked by mikhail.pozdnyakov@intel.com

[commit-bot: I haz the power, 2016-05-02 11:23:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1942713002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1942713002/20001

[commit-bot: I haz the power, 2016-05-02 11:26:59]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-05-02 11:28:40]

Description was changed from

==========
[chrome.displaySource][WiFi Display] Consider video encoder capabilities

Implementation considers the video encoder capabilities during video
formats negotiations with sink and picks the best video encoder profile
from the supported ones.

BUG=242107
==========

to

==========
[chrome.displaySource][WiFi Display] Consider video encoder capabilities

Implementation considers the video encoder capabilities during video
formats negotiations with sink and picks the best video encoder profile
from the supported ones.

BUG=242107

Committed: https://crrev.com/869826b7522e495b6104f169cdf64e5ccfc15350
Cr-Commit-Position: refs/heads/master@{#390918}
==========

[commit-bot: I haz the power, 2016-05-02 11:28:41]

Patchset 1 (id:??) landed as
https://crrev.com/869826b7522e495b6104f169cdf64e5ccfc15350
Cr-Commit-Position: refs/heads/master@{#390918}