Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js

Issue 1942683006: [Devtools] XMLView now searchable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@FIND_IN_JSON_FINAL
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js b/third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js
index b8d04875f5c45395704756a7f6bc76a5c307e38f..9f24b153f4abd93b154f806209a50472e2de5b91 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js
@@ -74,9 +74,18 @@ WebInspector.RequestPreviewView.prototype = {
toolbar.appendToolbarItem(item);
}
this.innerView = this._previewView;
+ this._previewViewHandledForTest(this._previewView);
}
},
+ /**
+ * @param {!WebInspector.Widget} view
+ */
+ _previewViewHandledForTest: function(view) { },
+
+ /**
+ * @return {!WebInspector.EmptyWidget}
+ */
_createEmptyWidget: function()
{
return this._createMessageView(WebInspector.UIString("This request has no preview available."));
@@ -112,13 +121,15 @@ WebInspector.RequestPreviewView.prototype = {
},
/**
- * @return {?WebInspector.XMLView}
+ * @return {?WebInspector.SearchableView}
*/
_xmlView: function()
{
var content = this._requestContent();
var parsedXML = WebInspector.XMLView.parseXML(content, this.request.mimeType);
- return parsedXML ? new WebInspector.XMLView(parsedXML) : null;
+ if (parsedXML)
+ return WebInspector.XMLView.createSearchableView(parsedXML);
+ return null;
},
/**

Powered by Google App Engine
This is Rietveld 408576698