third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js - Issue 1942683006: [Devtools] XMLView now searchable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js

Issue 1942683006: [Devtools] XMLView now searchable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@FIND_IN_JSON_FINAL

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/network/preview-searchable-expected.txt ('k') | third_party/WebKit/Source/devtools/front_end/network/XMLView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js b/third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js

index f7896b9d371404689d2c66ea4a617c705e23c04e..9f24b153f4abd93b154f806209a50472e2de5b91 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js

@@ -121,13 +121,15 @@ WebInspector.RequestPreviewView.prototype = {

/**

- * @return {?WebInspector.XMLView}

+ * @return {?WebInspector.SearchableView}

_xmlView: function()

{

var content = this._requestContent();

var parsedXML = WebInspector.XMLView.parseXML(content, this.request.mimeType);

- return parsedXML ? new WebInspector.XMLView(parsedXML) : null;

+ if (parsedXML)

lushnikov 2016/05/16 22:16:05 nit: return parsedXML ? WebInspector.XMLView.creat

+ return WebInspector.XMLView.createSearchableView(parsedXML);

+ return null;

/**