chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js - Issue 1942683005: Refactor event handler classes to make it easier to add new event type listeners.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js

Issue 1942683005: Refactor event handler classes to make it easier to add new event type listeners. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/chromevox/background/background.js ('k') | chrome/browser/resources/chromeos/chromevox/common/chrome_extension_externs.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js

diff --git a/chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js b/chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js

index 2b07f2f876d0297612e7510b92e59dc56ff50479..e9e9e4f8d78abecf764df0eede0bb89a168f35f7 100644

--- a/chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js

+++ b/chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js

@@ -199,7 +199,7 @@ cvox.TabsApiHandler.prototype = {

chrome.automation.getTree(tabId, function(node) {

if (this.handler_)

- this.handler_.unregister();

+ this.handler_.removeAllListeners();

this.handler_ = new TabsAutomationHandler(node);

}.bind(this));