Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 1942653002: Provide shipping address only to merchants that need it. (Closed)

Created:
4 years, 7 months ago by please use gerrit instead
Modified:
4 years, 7 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@integration-tests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Provide shipping address only to merchants that need it. If the merchant provides NULL shipping options, the merchant needs a shipping address to calculate shipping costs. The UI requires the user to make an address selection and passes that information to the merchant. If the merchant provides non-NULL shipping options, the merchant does not need shipping address to calculate shipping costs. The UI selects the default shipping address, but does not send it to the merchant until the user clicks "Pay". BUG=587995 Committed: https://crrev.com/c526a8e3f57decf22c644a3d9a9b28710c3b482e Cr-Commit-Position: refs/heads/master@{#391004}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 1 4 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
please use gerrit instead
dfalcantara@, ptal.
4 years, 7 months ago (2016-05-02 01:06:04 UTC) #2
gone
lgtm
4 years, 7 months ago (2016-05-02 17:44:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942653002/20001
4 years, 7 months ago (2016-05-02 17:47:47 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-02 18:35:38 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 18:37:57 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c526a8e3f57decf22c644a3d9a9b28710c3b482e
Cr-Commit-Position: refs/heads/master@{#391004}

Powered by Google App Engine
This is Rietveld 408576698