Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1942633002: Convert track-mode* tests to testharness.js (Closed)

Created:
4 years, 7 months ago by Srirama
Modified:
4 years, 7 months ago
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, philipj_slow, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert track-mode* tests to testharness.js Cleaning up track-mode* tests in media/track to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/ee51763e46f6fa5c8d9ce7213f38a4b27df0685f Cr-Commit-Position: refs/heads/master@{#391580}

Patch Set 1 #

Total comments: 3

Patch Set 2 : address comments #

Messages

Total messages: 11 (6 generated)
Srirama
PTAL
4 years, 7 months ago (2016-05-01 11:58:13 UTC) #3
mlamouri (slow - plz ping)
lgtm with comments applied. https://codereview.chromium.org/1942633002/diff/1/third_party/WebKit/LayoutTests/media/track/track-mode-triggers-loading.html File third_party/WebKit/LayoutTests/media/track/track-mode-triggers-loading.html (right): https://codereview.chromium.org/1942633002/diff/1/third_party/WebKit/LayoutTests/media/track/track-mode-triggers-loading.html#newcode23 third_party/WebKit/LayoutTests/media/track/track-mode-triggers-loading.html:23: // Check metadata track state. ...
4 years, 7 months ago (2016-05-04 13:55:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942633002/20001
4 years, 7 months ago (2016-05-04 17:35:29 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-04 18:39:56 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 18:41:32 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ee51763e46f6fa5c8d9ce7213f38a4b27df0685f
Cr-Commit-Position: refs/heads/master@{#391580}

Powered by Google App Engine
This is Rietveld 408576698