third_party/WebKit/Source/core/paint/ViewPainter.cpp - Issue 1942623002: Rename Document::ownerElement to localOwner and fix main frame checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/ViewPainter.cpp

Issue 1942623002: Rename Document::ownerElement to localOwner and fix main frame checks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed const changes and some gratuitous checks Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/paint/ViewPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/ViewPainter.cpp b/third_party/WebKit/Source/core/paint/ViewPainter.cpp

index f2dd9906b01e67d7e28335389f1fc2ce713e50f2..6883c0b049ed1acacc51e519abbf0f39e73e17f4 100644

--- a/third_party/WebKit/Source/core/paint/ViewPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/ViewPainter.cpp

@@ -56,7 +56,7 @@ void ViewPainter::paintBoxDecorationBackground(const PaintInfo& paintInfo)

IntRect backgroundRect = pixelSnappedIntRect(m_layoutView.layer()->boundingBoxForCompositing());

const Document& document = m_layoutView.document();

const FrameView& frameView = *m_layoutView.frameView();

- bool isMainFrame = !document.ownerElement();

+ bool isMainFrame = document.isInMainFrame();

bool paintsBaseBackground = isMainFrame && !frameView.isTransparent();

bool shouldClearCanvas = paintsBaseBackground && (document.settings() && document.settings()->shouldClearDocumentBackground());

Color baseBackgroundColor = paintsBaseBackground ? frameView.baseBackgroundColor() : Color();

« no previous file with comments | « third_party/WebKit/Source/core/page/TouchAdjustment.cpp ('k') | no next file » | no next file with comments »