third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp - Issue 1942623002: Rename Document::ownerElement to localOwner and fix main frame checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp

Issue 1942623002: Rename Document::ownerElement to localOwner and fix main frame checks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove duplication in const overload Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/Document.cpp ('K') | « third_party/WebKit/Source/core/dom/Node.cpp ('k') | third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp

diff --git a/third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp b/third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp

index 0f3d57d9727e351aa96330fcabdc8b0eb067d513..afcc99393165bc0c9899aa7de42e4217a486a3f7 100644

--- a/third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp

+++ b/third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp

@@ -273,7 +273,7 @@ void EventHandlerRegistry::documentDetached(Document& document)

const EventTargetSet* targets = &m_targets[handlerClass];

for (const auto& eventTarget : *targets) {

if (Node* node = eventTarget.key->toNode()) {

- for (Document* doc = &node->document(); doc; doc = doc->ownerElement() ? &doc->ownerElement()->document() : 0) {

+ for (Document* doc = &node->document(); doc; doc = doc->localOwnerElement() ? &doc->localOwnerElement()->document() : 0) {

if (doc == &document) {

targetsToRemove.append(eventTarget.key);

break;