Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1942593002: [Sync] Do not check IS_DIR bit on nigori node (Closed)

Created:
4 years, 7 months ago by Gang Wu
Modified:
4 years, 7 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, sync-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Do not check IS_DIR bit on nigori node Some older accounts have nigori nodes without IS_DIR bit set, so do not check on nigori node. BUG=607239 Committed: https://crrev.com/5a2ae139f2788c83123fac4538ad581766241747 Cr-Commit-Position: refs/heads/master@{#391054}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M sync/internal_api/base_node.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Gang Wu
PTAL
4 years, 7 months ago (2016-05-02 16:51:22 UTC) #4
Nicolas Zea
Could you fix the commit message? The message itself does not include the title of ...
4 years, 7 months ago (2016-05-02 16:52:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942593002/20001
4 years, 7 months ago (2016-05-02 16:55:23 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/168659)
4 years, 7 months ago (2016-05-02 17:16:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942593002/20001
4 years, 7 months ago (2016-05-02 21:16:58 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 7 months ago (2016-05-02 21:23:56 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 21:25:45 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a2ae139f2788c83123fac4538ad581766241747
Cr-Commit-Position: refs/heads/master@{#391054}

Powered by Google App Engine
This is Rietveld 408576698