DevTools: render parsed manifest data in the resources panel.

DevTools: render parsed manifest data in the resources panel.

BUG=607779
Committed: https://crrev.com/6316e6882ce8682f2d0f8a895dc99688962a2645
Cr-Commit-Position: refs/heads/master@{#390837}

[pfeldman, 2016-04-30 00:17:01]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2016-04-30 00:38:19]

lgtm

https://codereview.chromium.org/1942523002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js
(right):

https://codereview.chromium.org/1942523002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js:51:
var section = this._contentBox.createChild("div", "app-manifest-section")
style: semicolon missing

https://codereview.chromium.org/1942523002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js:134:
var imageElement = field.createChild("img");
Let's set style.width and style.height to not rely on the image served being the
right size and mess with our layout.

https://codereview.chromium.org/1942523002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js:135:
imageElement.src = WebInspector.ParsedURL.completeURL(url, icon["src"]);
Should we validate icon["src"] to disallow javascript: or other scary urls?

https://codereview.chromium.org/1942523002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
(right):

https://codereview.chromium.org/1942523002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js:465: *
@param {function(string, ?string,!Array<!PageAgent.AppManifestError>)} callback
style: space before comma

[pfeldman, 2016-04-30 01:03:06]

https://codereview.chromium.org/1942523002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js
(right):

https://codereview.chromium.org/1942523002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js:134:
var imageElement = field.createChild("img");
On 2016/04/30 00:38:19, dgozman wrote:
> Let's set style.width and style.height to not rely on the image served being
the
> right size and mess with our layout.

I'll use max-width and max-height.

https://codereview.chromium.org/1942523002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js:135:
imageElement.src = WebInspector.ParsedURL.completeURL(url, icon["src"]);
On 2016/04/30 00:38:19, dgozman wrote:
> Should we validate icon["src"] to disallow javascript: or other scary urls?

We would not execute scripts here.

[pfeldman, 2016-04-30 01:05:56]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-04-30 01:05:57]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1942523002/#ps20001
(title: "comments addressed")

[commit-bot: I haz the power, 2016-04-30 01:06:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1942523002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1942523002/20001

[commit-bot: I haz the power, 2016-04-30 02:35:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-30 17:30:59]

Patchset 2 (id:??) landed as
https://crrev.com/6316e6882ce8682f2d0f8a895dc99688962a2645
Cr-Commit-Position: refs/heads/master@{#390837}

[commit-bot: I haz the power, 2016-04-30 18:04:00]

Description was changed from

==========
DevTools: render parsed manifest data in the resources panel.

BUG=607779
==========

to

==========
DevTools: render parsed manifest data in the resources panel.

BUG=607779

Committed: https://crrev.com/6316e6882ce8682f2d0f8a895dc99688962a2645
Cr-Commit-Position: refs/heads/master@{#390837}
==========