Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: src/jump-target-ia32.cc

Issue 19425: Change FastCharCodeAt to use a virtual frame. (Closed) Base URL: http://v8.googlecode.com/svn/branches/experimental/toiger/
Patch Set: '' Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/jump-target.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/jump-target-ia32.cc
===================================================================
--- src/jump-target-ia32.cc (revision 1192)
+++ src/jump-target-ia32.cc (working copy)
@@ -112,6 +112,17 @@
}
+void JumpTarget::Jump(Result* arg0, Result* arg1, Result* arg2) {
+ ASSERT(cgen_ != NULL);
+ ASSERT(cgen_->has_valid_frame());
+
+ cgen_->frame()->Push(arg0);
+ cgen_->frame()->Push(arg1);
+ cgen_->frame()->Push(arg2);
+ Jump();
+}
+
+
void JumpTarget::Branch(Condition cc, Hint hint) {
ASSERT(cgen_ != NULL);
ASSERT(cgen_->has_valid_frame());
@@ -204,6 +215,67 @@
ASSERT_ARGCHECK(arg1);
}
+
+void JumpTarget::Branch(Condition cc,
+ Result* arg0,
+ Result* arg1,
+ Result* arg2,
+ Hint hint) {
+ ASSERT(cgen_ != NULL);
+ ASSERT(cgen_->frame() != NULL);
+
+ // We want to check that non-frame registers at the call site stay in
+ // the same registers on the fall-through branch.
+ DECLARE_ARGCHECK_VARS(arg0);
+ DECLARE_ARGCHECK_VARS(arg1);
+ DECLARE_ARGCHECK_VARS(arg2);
+
+ cgen_->frame()->Push(arg0);
+ cgen_->frame()->Push(arg1);
+ cgen_->frame()->Push(arg2);
+ Branch(cc, hint);
+ *arg2 = cgen_->frame()->Pop();
+ *arg1 = cgen_->frame()->Pop();
+ *arg0 = cgen_->frame()->Pop();
+
+ ASSERT_ARGCHECK(arg0);
+ ASSERT_ARGCHECK(arg1);
+ ASSERT_ARGCHECK(arg2);
+}
+
+
+void JumpTarget::Branch(Condition cc,
+ Result* arg0,
+ Result* arg1,
+ Result* arg2,
+ Result* arg3,
+ Hint hint) {
+ ASSERT(cgen_ != NULL);
+ ASSERT(cgen_->frame() != NULL);
+
+ // We want to check that non-frame registers at the call site stay in
+ // the same registers on the fall-through branch.
+ DECLARE_ARGCHECK_VARS(arg0);
+ DECLARE_ARGCHECK_VARS(arg1);
+ DECLARE_ARGCHECK_VARS(arg2);
+ DECLARE_ARGCHECK_VARS(arg3);
+
+ cgen_->frame()->Push(arg0);
+ cgen_->frame()->Push(arg1);
+ cgen_->frame()->Push(arg2);
+ cgen_->frame()->Push(arg3);
+ Branch(cc, hint);
+ *arg3 = cgen_->frame()->Pop();
+ *arg2 = cgen_->frame()->Pop();
+ *arg1 = cgen_->frame()->Pop();
+ *arg0 = cgen_->frame()->Pop();
+
+ ASSERT_ARGCHECK(arg0);
+ ASSERT_ARGCHECK(arg1);
+ ASSERT_ARGCHECK(arg2);
+ ASSERT_ARGCHECK(arg3);
+}
+
#undef DECLARE_ARGCHECK_VARS
#undef ASSERT_ARGCHECK
@@ -306,6 +378,38 @@
}
+void JumpTarget::Bind(Result* arg0, Result* arg1, Result* arg2) {
+ ASSERT(cgen_ != NULL);
+
+ if (cgen_->has_valid_frame()) {
+ cgen_->frame()->Push(arg0);
+ cgen_->frame()->Push(arg1);
+ cgen_->frame()->Push(arg2);
+ }
+ Bind();
+ *arg2 = cgen_->frame()->Pop();
+ *arg1 = cgen_->frame()->Pop();
+ *arg0 = cgen_->frame()->Pop();
+}
+
+
+void JumpTarget::Bind(Result* arg0, Result* arg1, Result* arg2, Result* arg3) {
+ ASSERT(cgen_ != NULL);
+
+ if (cgen_->has_valid_frame()) {
+ cgen_->frame()->Push(arg0);
+ cgen_->frame()->Push(arg1);
+ cgen_->frame()->Push(arg2);
+ cgen_->frame()->Push(arg3);
+ }
+ Bind();
+ *arg3 = cgen_->frame()->Pop();
+ *arg2 = cgen_->frame()->Pop();
+ *arg1 = cgen_->frame()->Pop();
+ *arg0 = cgen_->frame()->Pop();
+}
+
+
void JumpTarget::CopyTo(JumpTarget* destination) {
ASSERT(destination != NULL);
destination->cgen_ = cgen_;
« no previous file with comments | « src/jump-target.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698