Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1942493002: Short-term fix for Aura Desktop/Window capture. (Closed)

Created:
4 years, 7 months ago by miu
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Short-term fix for Aura Desktop/Window capture. The compositor is not reliably calling the OnCompositingEnded() observer method, causing capture to "freeze." However, it's not clear that AuraWindowCaptureMachine should have been using it to trigger copy requests in the first place. This change switches over to using the only other reliable feedback mechanism available (as of this writing). That is, we now use the OnAnimationStep() observer method as a trigger to initiate copy requests. Long-term, we need a better observer callback interface from the compositor for this use case. The solution here will always capture frames at the maximum framerate, which means CPU/GPU is being wasted on redundant captures, and the quality/smoothness of animating content will suffer significantly. BUG=492839, 600031 Review-Url: https://codereview.chromium.org/1922143004 Cr-Commit-Position: refs/heads/master@{#390156} (cherry picked from commit 1ca25389bc07e4cb43ccc46af8159b0291c7e5d5) Committed: https://chromium.googlesource.com/chromium/src/+/fdd26756b02ce6ae3b70ed99ce25155695f74b9e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -49 lines) Patch
M content/browser/media/capture/aura_window_capture_machine.h View 6 chunks +11 lines, -14 lines 0 comments Download
M content/browser/media/capture/aura_window_capture_machine.cc View 14 chunks +80 lines, -35 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
miu
4 years, 7 months ago (2016-04-29 23:38:24 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fdd26756b02ce6ae3b70ed99ce25155695f74b9e.

Powered by Google App Engine
This is Rietveld 408576698