Eliminate mojo:resource_provider

Now Catalog exposes the package resource directory to the calling application.

TODO: maybe it should expose the package directory?

R=sky@chromium.org
BUG=

Committed: https://crrev.com/9fe679e773cf7e459521fe6b7c0ac7c1cc4adae6
Cr-Commit-Position: refs/heads/master@{#391714}

[yzshen1, 2016-05-02 21:22:56]

yzshen@chromium.org changed reviewers:
+ yzshen@chromium.org

[yzshen1, 2016-05-02 21:22:56]

https://codereview.chromium.org/1942473002/diff/40001/services/catalog/catalo...
File services/catalog/catalog.cc (right):

https://codereview.chromium.org/1942473002/diff/40001/services/catalog/catalo...
services/catalog/catalog.cc:143: std::unique_ptr<base::ScopedTempDir>(),
After the fix, this line still failed because argument type mismatch.
But it seems irrelevant to bindings-internal issues.

[Ben Goodger (Google), 2016-05-02 23:55:05]

Description was changed from

==========
Catalog exposes the package directory to the calling application

BUG=
==========

to

==========
Now Catalog exposes the package resource directory to the calling application.

TODO: maybe it should expose the package directory?

R=sky@chromium.org
BUG=
==========

[Ben Goodger (Google), 2016-05-02 23:55:05]

ben@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2016-05-03 04:13:23]

https://codereview.chromium.org/1942473002/diff/160001/services/catalog/publi...
File services/catalog/public/cpp/resource_loader.cc (right):

https://codereview.chromium.org/1942473002/diff/160001/services/catalog/publi...
services/catalog/public/cpp/resource_loader.cc:29:
ResourceLoader::ResourceLoader(shell::Connector* connector,
This is a lot of expensive operations for the constructor. Seems like it should
be moved to a Load/Init function with a return value.

https://codereview.chromium.org/1942473002/diff/160001/services/catalog/publi...
services/catalog/public/cpp/resource_loader.cc:34:
mojo::Array<filesystem::FileOpenDetailsPtr> deets(
deets? You sure are going for obscure names lately.

https://codereview.chromium.org/1942473002/diff/160001/services/catalog/publi...
services/catalog/public/cpp/resource_loader.cc:47:
directory->OpenFileHandles(std::move(deets), &results);
You need to check the return value. I don't think this code or TakeFile should
check. It's entirely possible during shutdown this code could end up failing
and/or not get everything.

[Ben Goodger (Google), 2016-05-03 17:11:44]

Updated ptal

[sky, 2016-05-03 17:58:58]

LGTM - but please add test coverage.

https://codereview.chromium.org/1942473002/diff/200001/services/catalog/catal...
File services/catalog/catalog.cc (right):

https://codereview.chromium.org/1942473002/diff/200001/services/catalog/catal...
services/catalog/catalog.cc:134: new
filesystem::DirectoryImpl(std::move(request), resources_path,
nit: document DirectoryImpl deletes itself when connection goes away.

[Ben Goodger (Google), 2016-05-03 22:19:57]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-05-03 22:19:57]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1942473002/#ps220001
(title: ".")

[commit-bot: I haz the power, 2016-05-03 22:20:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1942473002/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1942473002/220001

[commit-bot: I haz the power, 2016-05-03 22:25:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-03 22:25:19]

Try jobs failed on following builders:
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Ben Goodger (Google), 2016-05-03 23:41:34]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-05-03 23:41:34]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1942473002/#ps240001
(title: ".")

[commit-bot: I haz the power, 2016-05-03 23:48:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1942473002/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1942473002/240001

[commit-bot: I haz the power, 2016-05-04 00:04:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 00:04:20]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2016-05-04 02:44:15]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-05-04 02:44:16]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1942473002/#ps260001
(title: ".")

[commit-bot: I haz the power, 2016-05-04 02:44:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1942473002/260001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1942473002/260001

[commit-bot: I haz the power, 2016-05-04 02:55:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 02:55:29]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2016-05-04 16:59:27]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-05-04 16:59:28]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1942473002/#ps280001
(title: ".")

[commit-bot: I haz the power, 2016-05-04 16:59:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1942473002/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1942473002/280001

[commit-bot: I haz the power, 2016-05-04 17:28:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 17:28:59]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Ben Goodger (Google), 2016-05-04 20:18:47]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-05-04 20:18:48]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1942473002/#ps300001
(title: ".")

[commit-bot: I haz the power, 2016-05-04 20:19:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1942473002/300001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1942473002/300001

[Ken Rockot(use gerrit already), 2016-05-04 20:54:01]

The CQ bit was unchecked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-05-04 20:54:11]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2016-05-04 20:54:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1942473002/300001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1942473002/300001

[commit-bot: I haz the power, 2016-05-04 21:25:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 21:25:05]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Ken Rockot(use gerrit already), 2016-05-04 22:45:55]

Let's add //mojo/platform_handle:platform_handle_impl as a dependency in
//content/common

[Ben Goodger (Google), 2016-05-04 23:00:05]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-05-04 23:00:05]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1942473002/#ps320001
(title: ".")

[commit-bot: I haz the power, 2016-05-04 23:00:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1942473002/320001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1942473002/320001

[commit-bot: I haz the power, 2016-05-05 00:27:25]

Description was changed from

==========
Now Catalog exposes the package resource directory to the calling application.

TODO: maybe it should expose the package directory?

R=sky@chromium.org
BUG=
==========

to

==========
Now Catalog exposes the package resource directory to the calling application.

TODO: maybe it should expose the package directory?

R=sky@chromium.org
BUG=
==========

[commit-bot: I haz the power, 2016-05-05 00:27:26]

Committed patchset #17 (id:320001)

[commit-bot: I haz the power, 2016-05-05 00:29:37]

Description was changed from

==========
Now Catalog exposes the package resource directory to the calling application.

TODO: maybe it should expose the package directory?

R=sky@chromium.org
BUG=
==========

to

==========
Now Catalog exposes the package resource directory to the calling application.

TODO: maybe it should expose the package directory?

R=sky@chromium.org
BUG=

Committed: https://crrev.com/9fe679e773cf7e459521fe6b7c0ac7c1cc4adae6
Cr-Commit-Position: refs/heads/master@{#391714}
==========

[commit-bot: I haz the power, 2016-05-05 00:29:38]

Patchset 17 (id:??) landed as
https://crrev.com/9fe679e773cf7e459521fe6b7c0ac7c1cc4adae6
Cr-Commit-Position: refs/heads/master@{#391714}