Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 1942463002: Revert of Add a PhysicalWebEnvironment class (Closed)

Created:
4 years, 7 months ago by mattreynolds
Modified:
4 years, 7 months ago
CC:
chromium-reviews, mmocny
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add a PhysicalWebEnvironment class (patchset #3 id:40001 of https://codereview.chromium.org/1927593004/ ) Reason for revert: Broke the GN build again (test failures): https://build.chromium.org/p/chromium.linux/builders/Android%20GN/builds/34043 Instrumentation test ChromePublicTest failures: org.chromium.chrome.browser.physicalweb.ListUrlsActivityTest#testUrlsListEmptyInOnboarding org.chromium.chrome.browser.physicalweb.UrlManagerTest#testAddUrlWhileOnboardingMakesNotification Original issue's description: > Add a PhysicalWebEnvironment class > > This class has a hasNotificationBasedClient method that will > allow us to disable notifications if there is another Physical Web > client showing notifications. > > BUG=604502 TBR=nyquist@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=604502 Committed: https://crrev.com/c8f36e844bf4f7545c23630f74632b7eb792666f Cr-Commit-Position: refs/heads/master@{#390813}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -55 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java View 2 chunks +1 line, -9 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebEnvironment.java View 1 chunk +0 lines, -37 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
mattreynolds
Created Revert of Add a PhysicalWebEnvironment class
4 years, 7 months ago (2016-04-29 22:18:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942463002/1
4 years, 7 months ago (2016-04-29 22:19:14 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-04-29 22:19:16 UTC) #4
jbudorick
lgtm
4 years, 7 months ago (2016-04-29 22:36:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942463002/1
4 years, 7 months ago (2016-04-30 00:08:02 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-30 00:08:57 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c8f36e844bf4f7545c23630f74632b7eb792666f Cr-Commit-Position: refs/heads/master@{#390813}
4 years, 7 months ago (2016-04-30 17:30:22 UTC) #13
mattreynolds
4 years, 7 months ago (2016-05-03 23:01:37 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1943353003/ by mattreynolds@chromium.org.

The reason for reverting is: Disabled the tests that were causing this to fail:

https://codereview.chromium.org/1937643002/.

Powered by Google App Engine
This is Rietveld 408576698