Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1942403002: run_isolated: close storage (Closed)

Created:
4 years, 7 months ago by nodir
Modified:
4 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/luci/luci-py@master
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

run_isolated: close storage Forgot to close storage on exit in a prev CL R=maruel@chromium.org BUG=601022 Committed: https://github.com/luci/luci-py/commit/0a8232ec95d18fda544896c0b7f348f09d7db4a8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M client/run_isolated.py View 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
nodir
PTAL
4 years, 7 months ago (2016-05-03 17:03:56 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942403002/1
4 years, 7 months ago (2016-05-03 17:03:57 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-03 17:06:08 UTC) #5
M-A Ruel
lgtm
4 years, 7 months ago (2016-05-03 17:12:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942403002/1
4 years, 7 months ago (2016-05-03 17:18:37 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 17:20:35 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/0a8232ec95d18fda544896c0b7f348f09d7db4a8

Powered by Google App Engine
This is Rietveld 408576698