Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1147)

Issue 1942383003: Disable ChromeRuntimeAPIDelegateTest.RequestUpdateCheck. (Closed)

Created:
4 years, 7 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 7 months ago
Reviewers:
oshima
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable ChromeRuntimeAPIDelegateTest.RequestUpdateCheck. This test leaves behind a RenderProcessHost that breaks other tests. Now that the culprit has been found we can re-enable the tests this one was breaking. BUG=608064 TBR=oshima@chromium.org NOTRY=True Committed: https://crrev.com/549717e6295bc71dcffb84ac7bf6952bcdd92115 Cr-Commit-Position: refs/heads/master@{#391376}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M tools/valgrind/gtest_exclude/unit_tests.gtest-drmemory_win32.txt View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942383003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942383003/1
4 years, 7 months ago (2016-05-03 22:13:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 22:18:01 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 22:19:34 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/549717e6295bc71dcffb84ac7bf6952bcdd92115
Cr-Commit-Position: refs/heads/master@{#391376}

Powered by Google App Engine
This is Rietveld 408576698