(reland) Move permission.mojom from WebKit/public/platform/ to components/

(reland) Move permission.mojom from WebKit/public/platform/ to components/

This reverts commit e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954 with fix.

Mojo permission interface is needed by other parts of Chromium, e.g.
media.
Hence move it to a more common place.

BUG=604503
TBR=mlamouri@chromium.org,dcheng@chromium.org
TEST=No functionality change.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305
Cr-Commit-Position: refs/heads/master@{#391441}

[xhwang, 2016-05-03 16:42:35]

Description was changed from

==========
(reland) Move permission.mojom from WebKit/public/platform/ to components/

This reverts commit e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954 with fix.

Mojo permission interface is needed by other parts of Chromium, e.g.
media.
Hence move it to a more common place.

BUG=604503
TEST=No functionality change.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
(reland) Move permission.mojom from WebKit/public/platform/ to components/

This reverts commit e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954 with fix.

Mojo permission interface is needed by other parts of Chromium, e.g.
media.
Hence move it to a more common place.

BUG=604503
TEST=No functionality change.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[xhwang, 2016-05-03 16:42:36]

xhwang@chromium.org changed reviewers:
+ dcheng@chromium.org, jam@chromium.org, mlamouri@chromium.org

[xhwang, 2016-05-03 19:32:59]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-03 19:33:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1942353002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1942353002/20001

[jam, 2016-05-03 19:38:54]

lgtm

[commit-bot: I haz the power, 2016-05-03 19:51:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-03 19:51:33]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xhwang, 2016-05-04 00:06:07]

The CQ bit was checked by xhwang@chromium.org

[xhwang, 2016-05-04 00:06:08]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1942353002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-05-04 00:06:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1942353002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1942353002/40001

[commit-bot: I haz the power, 2016-05-04 00:18:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 00:18:09]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[xhwang, 2016-05-04 04:01:49]

Description was changed from

==========
(reland) Move permission.mojom from WebKit/public/platform/ to components/

This reverts commit e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954 with fix.

Mojo permission interface is needed by other parts of Chromium, e.g.
media.
Hence move it to a more common place.

BUG=604503
TEST=No functionality change.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
(reland) Move permission.mojom from WebKit/public/platform/ to components/

This reverts commit e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954 with fix.

Mojo permission interface is needed by other parts of Chromium, e.g.
media.
Hence move it to a more common place.

BUG=604503
TBR= mlamouri@chromium.org,dcheng@chromium.org
TEST=No functionality change.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[xhwang, 2016-05-04 04:02:08]

Description was changed from

==========
(reland) Move permission.mojom from WebKit/public/platform/ to components/

This reverts commit e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954 with fix.

Mojo permission interface is needed by other parts of Chromium, e.g.
media.
Hence move it to a more common place.

BUG=604503
TBR= mlamouri@chromium.org,dcheng@chromium.org
TEST=No functionality change.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
(reland) Move permission.mojom from WebKit/public/platform/ to components/

This reverts commit e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954 with fix.

Mojo permission interface is needed by other parts of Chromium, e.g.
media.
Hence move it to a more common place.

BUG=604503
TBR=mlamouri@chromium.org,dcheng@chromium.org
TEST=No functionality change.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[xhwang, 2016-05-04 04:02:17]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2016-05-04 04:02:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1942353002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1942353002/40001

[commit-bot: I haz the power, 2016-05-04 04:07:49]

Description was changed from

==========
(reland) Move permission.mojom from WebKit/public/platform/ to components/

This reverts commit e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954 with fix.

Mojo permission interface is needed by other parts of Chromium, e.g.
media.
Hence move it to a more common place.

BUG=604503
TBR=mlamouri@chromium.org,dcheng@chromium.org
TEST=No functionality change.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
(reland) Move permission.mojom from WebKit/public/platform/ to components/

This reverts commit e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954 with fix.

Mojo permission interface is needed by other parts of Chromium, e.g.
media.
Hence move it to a more common place.

BUG=604503
TBR=mlamouri@chromium.org,dcheng@chromium.org
TEST=No functionality change.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-05-04 04:07:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-04 04:09:00]

Description was changed from

==========
(reland) Move permission.mojom from WebKit/public/platform/ to components/

This reverts commit e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954 with fix.

Mojo permission interface is needed by other parts of Chromium, e.g.
media.
Hence move it to a more common place.

BUG=604503
TBR=mlamouri@chromium.org,dcheng@chromium.org
TEST=No functionality change.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
(reland) Move permission.mojom from WebKit/public/platform/ to components/

This reverts commit e1a1e4e8a79b1fcb518808a3dc9ea46cc5ef3954 with fix.

Mojo permission interface is needed by other parts of Chromium, e.g.
media.
Hence move it to a more common place.

BUG=604503
TBR=mlamouri@chromium.org,dcheng@chromium.org
TEST=No functionality change.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305
Cr-Commit-Position: refs/heads/master@{#391441}
==========

[commit-bot: I haz the power, 2016-05-04 04:09:02]

Patchset 3 (id:??) landed as
https://crrev.com/f3b224aa8873e952b12a9d058155e2070a4c4305
Cr-Commit-Position: refs/heads/master@{#391441}

[Mathieu, 2016-05-04 15:20:17]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1943963004/ by mathp@chromium.org.

The reason for reverting is: Sorry, it's causing failures on many bots, reliably
on Google Chrome OS bot: 

https://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chr....

[xhwang, 2016-05-04 18:06:54]

jam/dcheng/mlamouri: I am not really familiar with gyp+mojo. Wondering if you
see anything obvious? Thanks!

The error is that when we build visitedlink_common we can't find
components/permissions/permission_status.mojom.h. But visitedlink_common is
depending on '../content/content.gyp:content_common', which depends on
'../components/components.gyp:permissions_mojo_bindings'. So I don't really
understand how this could happen.

Also, the bot start to fail on 17561:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Chrom...

My CL is in the build from as early as 17538:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Chrom...

But this may just be because some other targets were built before
visitedlink_common which generated the mojom.h files already.

FAILED:
obj/components/visitedlink/common/visitedlink_common.visitedlink_message_generator.o

/b/build/slave/cache/cipd/goma/gomacc
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
obj/components/visitedlink/common/visitedlink_common.visitedlink_message_generator.o.d
-DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DGOOGLE_CHROME_BUILD
-DCR_CLANG_REVISION=268373-1 -DENABLE_RLZ -DUI_COMPOSITOR_IMAGE_TRANSPORT
-DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1
-DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1
-DIMAGE_LOADER_EXTENSION=1 -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1
-DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_CDMS -DENABLE_NOTIFICATIONS
-DENABLE_TOPCHROME_MD=1 -DENABLE_WAYLAND_SERVER=1 -DUSE_UDEV
-DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PDF=1 -DENABLE_PLUGINS=1
-DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1
-DENABLE_PROD_WALLET_SERVICE=1 -DENABLE_PRINTING=1 -DENABLE_PRINT_PREVIEW=1
-DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1
-DENABLE_SUPERVISED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1
-DENABLE_HANGOUT_SERVICES_EXTENSION=1 -DV8_USE_EXTERNAL_STARTUP_DATA
-DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL
-DMOJO_USE_SYSTEM_IMPL -DUSE_LIBPCI=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1
-DOS_CHROMEOS=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG
-DNO_UNWIND_TABLES -DOFFICIAL_BUILD -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0
-D_FORTIFY_SOURCE=2 -Igen -I../../third_party/khronos -I../../gpu -I../..
-I../../skia/config -Igen/angle -I../../third_party/WebKit/Source
-I../../third_party/WebKit -Igen/third_party/WebKit -Werror -pthread
-fno-strict-aliasing -Wall -Wextra -Wno-unused-parameter
-Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC
-Wno-reserved-user-defined-literal -Xclang -load -Xclang
/b/build/slave/google-chrome-rel-chromeos/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so
-Xclang -add-plugin -Xclang find-bad-constructs -Xclang
-plugin-arg-find-bad-constructs -Xclang check-templates -Xclang
-plugin-arg-find-bad-constructs -Xclang follow-macro-expansion -Xclang
-plugin-arg-find-bad-constructs -Xclang check-implicit-copy-ctors -Xclang
-plugin-arg-find-bad-constructs -Xclang check-ipc -fcolor-diagnostics -g
-B/b/build/slave/google-chrome-rel-chromeos/build/src/third_party/binutils/Linux_x64/Release/bin
-Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration
-Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing
-Wno-deprecated-register -Wno-inconsistent-missing-override
-Wno-shift-negative-value -Wno-undefined-var-template -pthread
-I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -m64
-march=x86-64 -O2 -fno-ident -fdata-sections -ffunction-sections
-fno-unwind-tables -fno-asynchronous-unwind-tables -fno-exceptions -fno-rtti
-fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11  -c
../../components/visitedlink/common/visitedlink_message_generator.cc -o
obj/components/visitedlink/common/visitedlink_common.visitedlink_message_generator.o
In file included from
../../components/visitedlink/common/visitedlink_message_generator.cc:7:
In file included from
../../components/visitedlink/common/visitedlink_message_generator.h:7:
In file included from
../../components/visitedlink/common/visitedlink_messages.h:12:
../../content/public/common/common_param_traits_macros.h:12:10: fatal error:
'components/permissions/permission_status.mojom.h' file not found
#include "components/permissions/permission_status.mojom.h"
         ^
1 error generated.

[jam, 2016-05-06 15:55:49]

sorry just saw this comment. i had already replied on the reland cl to this. if
you have any more questions, please feel free to IM me.

On 2016/05/04 18:06:54, xhwang wrote:
> jam/dcheng/mlamouri: I am not really familiar with gyp+mojo. Wondering if you
> see anything obvious? Thanks!
> 
> The error is that when we build visitedlink_common we can't find
> components/permissions/permission_status.mojom.h. But visitedlink_common is
> depending on '../content/content.gyp:content_common', which depends on
> '../components/components.gyp:permissions_mojo_bindings'. So I don't really
> understand how this could happen.
> 
> Also, the bot start to fail on 17561:
>
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Chrom...
> 
> My CL is in the build from as early as 17538:
>
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Chrom...
> 
> But this may just be because some other targets were built before
> visitedlink_common which generated the mojom.h files already.
> 
> FAILED:
>
obj/components/visitedlink/common/visitedlink_common.visitedlink_message_generator.o
> 
> /b/build/slave/cache/cipd/goma/gomacc
> ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
>
obj/components/visitedlink/common/visitedlink_common.visitedlink_message_generator.o.d
> -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DGOOGLE_CHROME_BUILD
> -DCR_CLANG_REVISION=268373-1 -DENABLE_RLZ -DUI_COMPOSITOR_IMAGE_TRANSPORT
> -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1
> -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1
> -DIMAGE_LOADER_EXTENSION=1 -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1
> -DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_CDMS -DENABLE_NOTIFICATIONS
> -DENABLE_TOPCHROME_MD=1 -DENABLE_WAYLAND_SERVER=1 -DUSE_UDEV
> -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PDF=1
-DENABLE_PLUGINS=1
> -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1
> -DENABLE_PROD_WALLET_SERVICE=1 -DENABLE_PRINTING=1 -DENABLE_PRINT_PREVIEW=1
> -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1
> -DENABLE_SUPERVISED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1
> -DENABLE_HANGOUT_SERVICES_EXTENSION=1 -DV8_USE_EXTERNAL_STARTUP_DATA
> -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL
> -DMOJO_USE_SYSTEM_IMPL -DUSE_LIBPCI=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1
> -DOS_CHROMEOS=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG
> -DNO_UNWIND_TABLES -DOFFICIAL_BUILD -DNVALGRIND
-DDYNAMIC_ANNOTATIONS_ENABLED=0
> -D_FORTIFY_SOURCE=2 -Igen -I../../third_party/khronos -I../../gpu -I../..
> -I../../skia/config -Igen/angle -I../../third_party/WebKit/Source
> -I../../third_party/WebKit -Igen/third_party/WebKit -Werror -pthread
> -fno-strict-aliasing -Wall -Wextra -Wno-unused-parameter
> -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC
> -Wno-reserved-user-defined-literal -Xclang -load -Xclang
>
/b/build/slave/google-chrome-rel-chromeos/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so
> -Xclang -add-plugin -Xclang find-bad-constructs -Xclang
> -plugin-arg-find-bad-constructs -Xclang check-templates -Xclang
> -plugin-arg-find-bad-constructs -Xclang follow-macro-expansion -Xclang
> -plugin-arg-find-bad-constructs -Xclang check-implicit-copy-ctors -Xclang
> -plugin-arg-find-bad-constructs -Xclang check-ipc -fcolor-diagnostics -g
>
-B/b/build/slave/google-chrome-rel-chromeos/build/src/third_party/binutils/Linux_x64/Release/bin
> -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration
> -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing
> -Wno-deprecated-register -Wno-inconsistent-missing-override
> -Wno-shift-negative-value -Wno-undefined-var-template -pthread
> -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -m64
> -march=x86-64 -O2 -fno-ident -fdata-sections -ffunction-sections
> -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-exceptions -fno-rtti
> -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11  -c
> ../../components/visitedlink/common/visitedlink_message_generator.cc -o
>
obj/components/visitedlink/common/visitedlink_common.visitedlink_message_generator.o
> In file included from
> ../../components/visitedlink/common/visitedlink_message_generator.cc:7:
> In file included from
> ../../components/visitedlink/common/visitedlink_message_generator.h:7:
> In file included from
> ../../components/visitedlink/common/visitedlink_messages.h:12:
> ../../content/public/common/common_param_traits_macros.h:12:10: fatal error:
> 'components/permissions/permission_status.mojom.h' file not found
> #include "components/permissions/permission_status.mojom.h"
>          ^
> 1 error generated.