Fix a used-after-free caused by an unremoved Observer.

chrome/browser/ui/webui/settings/profile_info_handler.h

Index: chrome/browser/ui/webui/settings/profile_info_handler.h
diff --git a/chrome/browser/ui/webui/settings/profile_info_handler.h b/chrome/browser/ui/webui/settings/profile_info_handler.h
index e0ab2adbc3688ee78d597cc9ffb892f4643e3104..9159f18eb4bbb57059aba061b2e153f3f99ec81c 100644
--- a/chrome/browser/ui/webui/settings/profile_info_handler.h
+++ b/chrome/browser/ui/webui/settings/profile_info_handler.h
@@ -8,6 +8,7 @@
 #include <memory>
 
 #include "base/macros.h"
+#include "base/scoped_observer.h"
 #include "build/build_config.h"
 #include "chrome/browser/profiles/profile_attributes_storage.h"
 #include "chrome/browser/ui/webui/settings/settings_page_ui_handler.h"
@@ -30,7 +31,7 @@ class ProfileInfoHandler : public SettingsPageUIHandler,
   static const char kProfileInfoChangedEventName[];
 
   explicit ProfileInfoHandler(Profile* profile);
-  ~ProfileInfoHandler() override {}
+  ~ProfileInfoHandler() override;
 
   // SettingsPageUIHandler implementation.
   void RegisterMessages() override;
@@ -63,6 +64,8 @@ class ProfileInfoHandler : public SettingsPageUIHandler,
   // Weak pointer.
   Profile* profile_;
 
+  ScopedObserver<ProfileAttributesStorage, ProfileInfoHandler> scoped_observer_;

[tommycli, 2016/05/03 17:23:48]

Can we call this profile_observer_ just to be clear?

[anthonyvd, 2016/05/03 18:12:10]

Done.

+
 #if defined(OS_CHROMEOS)
   // Used to listen to ChromeOS user image changes.
   content::NotificationRegistrar registrar_;