Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1942293002: Add missing initializer for FieldAccess' write_barrier_kind field (Closed)

Created:
4 years, 7 months ago by Jakob Kummerow
Modified:
4 years, 7 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com, Michael Lippautz, Benedikt Meurer
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add missing initializer for FieldAccess' write_barrier_kind field Omitting the initializer will give zero-initialization which is equivalent to kNoWriteBarrier. Committed: https://crrev.com/96a4d20ce233b75c42e01e4310c2c0cee5df59c0 Cr-Commit-Position: refs/heads/master@{#35989}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/compiler/js-create-lowering.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Jakob Kummerow
Jaro: PTAL. Michael, Benedikt: FYI.
4 years, 7 months ago (2016-05-03 13:59:55 UTC) #2
Jarin
lgtm. Thanks!
4 years, 7 months ago (2016-05-03 14:04:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942293002/1
4 years, 7 months ago (2016-05-03 14:04:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 14:27:18 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/96a4d20ce233b75c42e01e4310c2c0cee5df59c0 Cr-Commit-Position: refs/heads/master@{#35989}
4 years, 7 months ago (2016-05-03 14:27:54 UTC) #8
Benedikt Meurer
4 years, 7 months ago (2016-05-03 15:33:05 UTC) #10
Message was sent while issue was closed.
These days when I hate C++ so much.... thanks a lot for fixing, Jakob!

Powered by Google App Engine
This is Rietveld 408576698