Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 1942283003: [headless] Do not use libpci with headless. (Closed)

Created:
4 years, 7 months ago by altimin
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[headless] Do not use libpci with headless. Headless doesn't use GPU, therefore it doesn't need libpci. R=alexclarke@chromium.org,skyostil@chromium.org BUG=546953 Committed: https://crrev.com/34badeba15b5cd8861b143daeba32093ce9352c4 Cr-Commit-Position: refs/heads/master@{#391298}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/args/headless.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
altimin
4 years, 7 months ago (2016-05-03 17:04:01 UTC) #1
alex clarke (OOO till 29th)
Please explain why in the patch summary :)
4 years, 7 months ago (2016-05-03 17:07:03 UTC) #2
altimin
On 2016/05/03 17:07:03, alex clarke wrote: > Please explain why in the patch summary :) ...
4 years, 7 months ago (2016-05-03 17:16:06 UTC) #4
alex clarke (OOO till 29th)
lgtm
4 years, 7 months ago (2016-05-03 17:29:02 UTC) #5
altimin
+dpranke@ Hi, can you please approve this small change to headless configuration?
4 years, 7 months ago (2016-05-03 17:36:02 UTC) #7
Dirk Pranke
lgtm
4 years, 7 months ago (2016-05-03 17:46:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942283003/1
4 years, 7 months ago (2016-05-03 17:51:54 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 18:11:00 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 18:12:43 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34badeba15b5cd8861b143daeba32093ce9352c4
Cr-Commit-Position: refs/heads/master@{#391298}

Powered by Google App Engine
This is Rietveld 408576698