[Cronet] Resurrect Android USB reverse tethering

[Cronet] Resurrect Android USB reverse tethering

This was removed in crrev.com/1828703004 but is needed for Cronet
perf test.  This python script sets up USB reverse tethering for
an Android device, thereby allowing extremely fast networking
between the device and host computer.  Upon successful initialization
of USB reverse tethering, a network interface should be up on both
the device and host computer and provisioned with an IP address
allowing routing of packets between the device and host computer.

Committed: https://crrev.com/ce7be43d95149a1a97a6b4088127fe0cfe895831
Cr-Commit-Position: refs/heads/master@{#391280}

[pauljensen, 2016-05-03 12:56:40]

pauljensen@chromium.org changed reviewers:
+ mef@chromium.org

[pauljensen, 2016-05-03 12:56:41]

Misha, PTAL.  I dunno if you really want to review android_rndis_forwarder.py,
it's 99% a copy of the removed portion of
https://codereview.chromium.org/1828703004/diff/20001/telemetry/telemetry/int...

[mef, 2016-05-03 13:33:06]

On 2016/05/03 12:56:41, pauljensen wrote:
> Misha, PTAL.  I dunno if you really want to review android_rndis_forwarder.py,
> it's 99% a copy of the removed portion of
>
https://codereview.chromium.org/1828703004/diff/20001/telemetry/telemetry/int...

Looks fine. Does it make sense to add more elaborate description?

I wonder whether 'android_rndis_forwarder.py' could be useful apart from perf
tests, e.g. in manual debug setup, or somesuch? 
If so, should we describe its usage?

[pauljensen, 2016-05-03 16:41:17]

Description was changed from

==========
[Cronet] Resurrect Android USB reverse tethering

This was removed in crrev.com/1828703004 but is needed for Cronet
perf test.
==========

to

==========
[Cronet] Resurrect Android USB reverse tethering

This was removed in crrev.com/1828703004 but is needed for Cronet
perf test.  This python script sets up USB reverse tethering for
an Android device, thereby allowing extremely fast networking
between the device and host computer.  Upon successful initialization
of USB reverse tethering, a network interface should be up on both
the device and host computer and provisioned with an IP address
allowing routing of packets between the device and host computer.
==========

[pauljensen, 2016-05-03 16:43:49]

On 2016/05/03 13:33:06, mef wrote:
> On 2016/05/03 12:56:41, pauljensen wrote:
> > Misha, PTAL.  I dunno if you really want to review
android_rndis_forwarder.py,
> > it's 99% a copy of the removed portion of
> >
>
https://codereview.chromium.org/1828703004/diff/20001/telemetry/telemetry/int...
> 
> Looks fine. Does it make sense to add more elaborate description?
Done.

> 
> I wonder whether 'android_rndis_forwarder.py' could be useful apart from perf
> tests, e.g. in manual debug setup, or somesuch? 
> If so, should we describe its usage?
I think android_rndis_forwarder.py is not useful for manual setups as it is
somewhat tied to telemetry workings, e.g. it requires a "devil" Android device
parameter to setup which I assume cannot easily be passed on the command line.

[mef, 2016-05-03 16:52:33]

lgtm

[pauljensen, 2016-05-03 16:53:06]

The CQ bit was checked by pauljensen@chromium.org

[commit-bot: I haz the power, 2016-05-03 16:54:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1942283002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1942283002/20001

[commit-bot: I haz the power, 2016-05-03 17:30:21]

Description was changed from

==========
[Cronet] Resurrect Android USB reverse tethering

This was removed in crrev.com/1828703004 but is needed for Cronet
perf test.  This python script sets up USB reverse tethering for
an Android device, thereby allowing extremely fast networking
between the device and host computer.  Upon successful initialization
of USB reverse tethering, a network interface should be up on both
the device and host computer and provisioned with an IP address
allowing routing of packets between the device and host computer.
==========

to

==========
[Cronet] Resurrect Android USB reverse tethering

This was removed in crrev.com/1828703004 but is needed for Cronet
perf test.  This python script sets up USB reverse tethering for
an Android device, thereby allowing extremely fast networking
between the device and host computer.  Upon successful initialization
of USB reverse tethering, a network interface should be up on both
the device and host computer and provisioned with an IP address
allowing routing of packets between the device and host computer.
==========

[commit-bot: I haz the power, 2016-05-03 17:30:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-03 17:31:53]

Description was changed from

==========
[Cronet] Resurrect Android USB reverse tethering

This was removed in crrev.com/1828703004 but is needed for Cronet
perf test.  This python script sets up USB reverse tethering for
an Android device, thereby allowing extremely fast networking
between the device and host computer.  Upon successful initialization
of USB reverse tethering, a network interface should be up on both
the device and host computer and provisioned with an IP address
allowing routing of packets between the device and host computer.
==========

to

==========
[Cronet] Resurrect Android USB reverse tethering

This was removed in crrev.com/1828703004 but is needed for Cronet
perf test.  This python script sets up USB reverse tethering for
an Android device, thereby allowing extremely fast networking
between the device and host computer.  Upon successful initialization
of USB reverse tethering, a network interface should be up on both
the device and host computer and provisioned with an IP address
allowing routing of packets between the device and host computer.

Committed: https://crrev.com/ce7be43d95149a1a97a6b4088127fe0cfe895831
Cr-Commit-Position: refs/heads/master@{#391280}
==========

[commit-bot: I haz the power, 2016-05-03 17:31:58]

Patchset 2 (id:??) landed as
https://crrev.com/ce7be43d95149a1a97a6b4088127fe0cfe895831
Cr-Commit-Position: refs/heads/master@{#391280}