Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 1942273003: [WebViewShell] retarget the shell to N for testing. (Closed)

Created:
4 years, 7 months ago by timvolodine
Modified:
4 years, 7 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WebViewShell] retarget the shell to N for testing. Increase targetSdkVersion to 24 to be able to execute specific manual tests on N, e.g. geolocation api on insecure origins. BUG=603574 Committed: https://crrev.com/f2ec5e07edc351ea4a8dda1fca6f78eb649b2530 Cr-Commit-Position: refs/heads/master@{#391485}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M android_webview/tools/system_webview_shell/apk/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
timvolodine
4 years, 7 months ago (2016-05-03 17:35:40 UTC) #2
timvolodine
4 years, 7 months ago (2016-05-03 17:36:05 UTC) #4
sgurun-gerrit only
On 2016/05/03 17:36:05, timvolodine wrote: lgtm since this is only needed for testing a special ...
4 years, 7 months ago (2016-05-03 18:23:20 UTC) #5
timvolodine
4 years, 7 months ago (2016-05-03 18:23:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942273003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942273003/1
4 years, 7 months ago (2016-05-04 12:37:16 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 12:50:22 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 12:51:46 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f2ec5e07edc351ea4a8dda1fca6f78eb649b2530
Cr-Commit-Position: refs/heads/master@{#391485}

Powered by Google App Engine
This is Rietveld 408576698