Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1942273002: Crash on channel error in single-process mode. (Closed)

Created:
4 years, 7 months ago by Torne
Modified:
4 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Crash on channel error in single-process mode. If the renderer gets a channel error in single process mode, something has gone very wrong; it won't be possible for the browser to start a new renderer as it's not possible to restart it in single-process mode, so just crash right now to make the stack more clearly point at the culprit. BUG=514141 Committed: https://crrev.com/88b66452fff32a11b4db1dbfe486acd9fa8617b0 Cr-Commit-Position: refs/heads/master@{#391217}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M content/renderer/render_thread_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942273002/1
4 years, 7 months ago (2016-05-03 12:02:36 UTC) #2
Torne
Companion to https://codereview.chromium.org/1900513003/ I think it'd be reasonable to land this and leave it there ...
4 years, 7 months ago (2016-05-03 12:03:57 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 7 months ago (2016-05-03 12:05:20 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-03 12:57:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942273002/1
4 years, 7 months ago (2016-05-03 13:18:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 13:22:23 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 13:23:52 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88b66452fff32a11b4db1dbfe486acd9fa8617b0
Cr-Commit-Position: refs/heads/master@{#391217}

Powered by Google App Engine
This is Rietveld 408576698