Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 1942263002: Fix a test expectation that current year is >= 2011. (Closed)

Created:
4 years, 7 months ago by Florian Schneider
Modified:
4 years, 7 months ago
Reviewers:
floitsch, kustermann
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix a test expectation that current year is >= 2011. This causes test failures on devices where the date is set to earlier than 2011. BUG= R=kustermann@google.com Committed: https://github.com/dart-lang/sdk/commit/bef7b117d6cd73ee88217453f423be4369b7bbb5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests/corelib/core_runtime_types_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
4 years, 7 months ago (2016-05-03 11:39:24 UTC) #2
kustermann
LGTM
4 years, 7 months ago (2016-05-03 11:47:31 UTC) #3
Florian Schneider
4 years, 7 months ago (2016-05-03 12:28:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bef7b117d6cd73ee88217453f423be4369b7bbb5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698